From: Peter Korsgaard <peter@korsgaard.com>
To: cgel.zte@gmail.com
Cc: santoshkumar.yadav@barco.com, peter.korsgaard@barco.com,
hdegoede@redhat.com, markgross@kernel.org,
platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org,
ran jianping <ran.jianping@zte.com.cn>,
Zeal Robot <zealci@zte.com.cn>
Subject: Re: [PATCH] platform/x86: remove duplicate include in barco-p50-gpio.c
Date: Wed, 27 Oct 2021 10:19:54 +0200 [thread overview]
Message-ID: <87v91iriad.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20211027081516.1865-1-ran.jianping@zte.com.cn> (cgel zte's message of "Wed, 27 Oct 2021 08:15:16 +0000")
>>>>> "cgel" == cgel zte <cgel.zte@gmail.com> writes:
> From: ran jianping <ran.jianping@zte.com.cn>
> 'linux/io.h' included in 'drivers/platform/x86/barco-p50-gpio.c'
> is duplicated.It is also included on the 17 line.
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: ran jianping <ran.jianping@zte.com.cn>
> ---
> drivers/platform/x86/barco-p50-gpio.c | 1 -
> 1 file changed, 1 deletion(-)
> diff --git a/drivers/platform/x86/barco-p50-gpio.c b/drivers/platform/x86/barco-p50-gpio.c
> index f5c72e33f9ae..bb8ed8e95225 100644
> --- a/drivers/platform/x86/barco-p50-gpio.c
> +++ b/drivers/platform/x86/barco-p50-gpio.c
> @@ -14,7 +14,6 @@
> #include <linux/delay.h>
> #include <linux/dmi.h>
> #include <linux/err.h>
> -#include <linux/io.h>
It probably makes more sense to drop the include from line 17 to keep
alphabetical ordering, but otherwise it looks good to.
With that fixed:
Acked-by: Peter Korsgaard <peter@korsgaard.com>
--
Bye, Peter Korsgaard
prev parent reply other threads:[~2021-10-27 8:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-27 8:15 [PATCH] platform/x86: remove duplicate include in barco-p50-gpio.c cgel.zte
2021-10-27 8:19 ` Peter Korsgaard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v91iriad.fsf@dell.be.48ers.dk \
--to=peter@korsgaard.com \
--cc=cgel.zte@gmail.com \
--cc=hdegoede@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=markgross@kernel.org \
--cc=peter.korsgaard@barco.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=ran.jianping@zte.com.cn \
--cc=santoshkumar.yadav@barco.com \
--cc=zealci@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox