From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 59D81C04FF3 for ; Mon, 24 May 2021 08:32:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 33D57610CE for ; Mon, 24 May 2021 08:32:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232413AbhEXIeO (ORCPT ); Mon, 24 May 2021 04:34:14 -0400 Received: from mail.kernel.org ([198.145.29.99]:46220 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232306AbhEXIeN (ORCPT ); Mon, 24 May 2021 04:34:13 -0400 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4D8096113B; Mon, 24 May 2021 08:32:46 +0000 (UTC) Received: from 78.163-31-62.static.virginmediabusiness.co.uk ([62.31.163.78] helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1ll60y-003Aa8-80; Mon, 24 May 2021 09:32:44 +0100 Date: Mon, 24 May 2021 09:32:36 +0100 Message-ID: <87v978wmzf.wl-maz@kernel.org> From: Marc Zyngier To: Rob Herring Cc: "linux-kernel@vger.kernel.org" , Thomas Gleixner , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Ley Foon Tan , Chris Zankel , Max Filippov , Vineet Gupta , Thomas Bogendoerfer , Robert Jarzmik , Russell King , Krzysztof Kozlowski , Yoshinori Sato , Rich Felker , Geert Uytterhoeven , Alex Deucher , Christian =?UTF-8?B?S8O2bmln?= , David Airlie , Daniel Vetter , Rob Clark , Linus Walleij , Lee Jones , Lorenzo Pieralisi , Bjorn Helgaas , Bartosz Golaszewski , Android Kernel Team Subject: Re: [PATCH 34/39] ARM: Bulk conversion to generic_handle_domain_irq() In-Reply-To: References: <20210520163751.27325-1-maz@kernel.org> <20210520163751.27325-35-maz@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 62.31.163.78 X-SA-Exim-Rcpt-To: robh@kernel.org, linux-kernel@vger.kernel.org, tglx@linutronix.de, mpe@ellerman.id.au, benh@kernel.crashing.org, paulus@samba.org, ley.foon.tan@intel.com, chris@zankel.net, jcmvbkbc@gmail.com, vgupta@synopsys.com, tsbogend@alpha.franken.de, robert.jarzmik@free.fr, linux@armlinux.org.uk, krzysztof.kozlowski@canonical.com, ysato@users.sourceforge.jp, dalias@libc.org, geert@linux-m68k.org, alexander.deucher@amd.com, christian.koenig@amd.com, airlied@linux.ie, daniel@ffwll.ch, robdclark@gmail.com, linus.walleij@linaro.org, lee.jones@linaro.org, lorenzo.pieralisi@arm.com, bhelgaas@google.com, bgolaszewski@baylibre.com, kernel-team@android.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 20 May 2021 19:04:17 +0100, Rob Herring wrote: > > On Thu, May 20, 2021 at 11:58 AM Marc Zyngier wrote: > > > > Wherever possible, replace constructs that match either > > generic_handle_irq(irq_find_mapping()) or > > generic_handle_irq(irq_linear_revmap()) to a single call to > > generic_handle_domain_irq(). > > > > Signed-off-by: Marc Zyngier > > --- > > arch/arm/mach-pxa/pxa_cplds_irqs.c | 6 ++---- > > arch/arm/mach-s3c/irq-s3c24xx.c | 5 ++--- > > 2 files changed, 4 insertions(+), 7 deletions(-) > > > > diff --git a/arch/arm/mach-pxa/pxa_cplds_irqs.c b/arch/arm/mach-pxa/pxa_cplds_irqs.c > > index ec0d9b094744..ce1bbabbad54 100644 > > --- a/arch/arm/mach-pxa/pxa_cplds_irqs.c > > +++ b/arch/arm/mach-pxa/pxa_cplds_irqs.c > > @@ -39,10 +39,8 @@ static irqreturn_t cplds_irq_handler(int in_irq, void *d) > > > > do { > > pending = readl(fpga->base + FPGA_IRQ_SET_CLR) & fpga->irq_mask; > > - for_each_set_bit(bit, &pending, CPLDS_NB_IRQ) { > > - generic_handle_irq(irq_find_mapping(fpga->irqdomain, > > - bit)); > > - } > > + for_each_set_bit(bit, &pending, CPLDS_NB_IRQ) > > + generic_handle_domain_irq(fpga->irqdomain, bit); > > We see this pattern a bit, I'm wondering if we can come up with a > common helper. For an even longer name, something like: > > generic_handle_domain_irq_for_bitmap(fpga->irqdomain, &pending, CPLDS_NB_IRQ); Maybe. However, people may want to (should?) do something when generic_handle_domain_irq() returns an error, and this wrapper would hide the error entirely (and being a secondary interrupt controller, things are as non-standard as you can imagine them). If we can come up with a common approach for most of the bitmap-driven I'd be happy to add something to that effect. Not as part of this series though. Thanks, M. -- Without deviation from the norm, progress is not possible.