From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 527B1C64E7D for ; Sun, 29 Nov 2020 11:12:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1458B20771 for ; Sun, 29 Nov 2020 11:12:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727420AbgK2LMH convert rfc822-to-8bit (ORCPT ); Sun, 29 Nov 2020 06:12:07 -0500 Received: from relay10.mail.gandi.net ([217.70.178.230]:34165 "EHLO relay10.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726428AbgK2LMH (ORCPT ); Sun, 29 Nov 2020 06:12:07 -0500 Received: from localhost (91-175-115-186.subs.proxad.net [91.175.115.186]) (Authenticated sender: gregory.clement@bootlin.com) by relay10.mail.gandi.net (Postfix) with ESMTPSA id 9535D240006; Sun, 29 Nov 2020 11:11:24 +0000 (UTC) From: Gregory CLEMENT To: Pali =?utf-8?Q?Roh=C3=A1r?= , Jason Cooper , Andrew Lunn , Sebastian Hesselbarth , Rob Herring , Andre Heider , =?utf-8?Q?G=C3=A9rald?= Kerma Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] arm64: dts: marvell: espressobin: Add support for LED2 In-Reply-To: <20201006124455.16617-1-pali@kernel.org> References: <20201006124455.16617-1-pali@kernel.org> Date: Sun, 29 Nov 2020 12:11:24 +0100 Message-ID: <87v9doju3n.fsf@BL-laptop> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Pali, > LED2 is connected to MPP1_2 pin. It is working only on V7 boards. > V5 boards have hw bug which cause that LED2 is non-working. > > So enable LED2 only for Espressobin V7 boards. > > Note that LED1 is connected to LED_WLAN# pin on miniPCIe card and LED3 to > power supply. Therefore on Espressobin board only LED2 can be controlled > directly from the host. LED1 is possible to control via WiFi card inserted > in miniPCIe slot if driver for particular card supports it. > > Signed-off-by: Pali Rohár > Tested-by: Gérald Kerma Applied on mvebu/dt64 Thanks, Gregory > > --- > > Previous version of this patch was sent by Uwe in March 2018, but it did > not work on any tested V5 board. Now we know it was due to V5 HW bug. > > https://lore.kernel.org/linux-arm-kernel/20180321105005.18426-3-u.kleine-koenig@pengutronix.de/ > --- > .../dts/marvell/armada-3720-espressobin-v7-emmc.dts | 4 ++++ > .../boot/dts/marvell/armada-3720-espressobin-v7.dts | 4 ++++ > .../boot/dts/marvell/armada-3720-espressobin.dtsi | 13 +++++++++++++ > 3 files changed, 21 insertions(+) > > diff --git a/arch/arm64/boot/dts/marvell/armada-3720-espressobin-v7-emmc.dts b/arch/arm64/boot/dts/marvell/armada-3720-espressobin-v7-emmc.dts > index 4775a7eda481..75401eab4d42 100644 > --- a/arch/arm64/boot/dts/marvell/armada-3720-espressobin-v7-emmc.dts > +++ b/arch/arm64/boot/dts/marvell/armada-3720-espressobin-v7-emmc.dts > @@ -39,3 +39,7 @@ > &sdhci0 { > status = "okay"; > }; > + > +&led2 { > + status = "okay"; > +}; > diff --git a/arch/arm64/boot/dts/marvell/armada-3720-espressobin-v7.dts b/arch/arm64/boot/dts/marvell/armada-3720-espressobin-v7.dts > index c47a93978386..48a7f50fb427 100644 > --- a/arch/arm64/boot/dts/marvell/armada-3720-espressobin-v7.dts > +++ b/arch/arm64/boot/dts/marvell/armada-3720-espressobin-v7.dts > @@ -34,3 +34,7 @@ > &switch0port3 { > label = "wan"; > }; > + > +&led2 { > + status = "okay"; > +}; > diff --git a/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dtsi b/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dtsi > index 8a1c678bea5f..daffe136c523 100644 > --- a/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dtsi > +++ b/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dtsi > @@ -41,6 +41,19 @@ > 3300000 0x0>; > enable-active-high; > }; > + > + led2: gpio-led2 { > + /* led2 is working only on v7 board */ > + status = "disabled"; > + > + compatible = "gpio-leds"; > + > + led2 { > + label = "led2"; > + gpios = <&gpionb 2 GPIO_ACTIVE_LOW>; > + default-state = "off"; > + }; > + }; > }; > > /* J9 */ > -- > 2.20.1 > -- Gregory Clement, Bootlin Embedded Linux and Kernel engineering http://bootlin.com