Re: [PATCH 4/5] x86: wire up TIF_NOTIFY_SIGNAL

Oleg Nesterov
2020-10-15T14:37:14Z

On 10/15, Jens Axboe wrote:
>
> static void handle_signal_work(ti_work, regs)
> {
> if (ti_work & _TIF_NOTIFY_SIGNAL)
> tracehook_notify_signal();
>
> if (ti_work & _TIF_SIGPENDING)
> arch_do_signal(regs);
> }
>
> and then we can skip modifying arch_do_signal() all together, as it'll
> only be called if _TIF_SIGPENDING is set.

No, this can't work. We need to restart the syscall if TIF_NOTIFY_SIGNAL.

Oleg.