From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC473C2D0C0 for ; Mon, 23 Dec 2019 21:42:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9C910207FF for ; Mon, 23 Dec 2019 21:42:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726879AbfLWVmi (ORCPT ); Mon, 23 Dec 2019 16:42:38 -0500 Received: from mga07.intel.com ([134.134.136.100]:44984 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726817AbfLWVmi (ORCPT ); Mon, 23 Dec 2019 16:42:38 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 23 Dec 2019 13:42:37 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,349,1571727600"; d="scan'208";a="417383532" Received: from adixit-mobl.amr.corp.intel.com (HELO adixit-arch.intel.com) ([10.254.180.4]) by fmsmga005.fm.intel.com with ESMTP; 23 Dec 2019 13:42:36 -0800 Date: Mon, 23 Dec 2019 13:42:36 -0800 Message-ID: <87v9q6afcj.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Greg KH Cc: Yi Wang , , , , , , , , , , , Huang Zijiang Subject: Re: [PATCH] misc: Use kzalloc() instead of kmalloc() with flag GFP_ZERO. In-Reply-To: <20191223120428.GB114474@kroah.com> References: <1577065918-25513-1-git-send-email-wang.yi59@zte.com.cn> <20191223120428.GB114474@kroah.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL/10.8 EasyPG/1.0.0 Emacs/26 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 23 Dec 2019 04:04:28 -0800, Greg KH wrote: > > On Mon, Dec 23, 2019 at 09:51:58AM +0800, Yi Wang wrote: > > From: Huang Zijiang > > > > Use kzalloc instead of manually setting kmalloc > > with flag GFP_ZERO since kzalloc sets allocated memory > > to zero. > > > > Signed-off-by: Huang Zijiang > > Signed-off-by: Yi Wang > > --- > > drivers/misc/mic/host/mic_boot.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/misc/mic/host/mic_boot.c b/drivers/misc/mic/host/mic_boot.c > > index 7335759..c1f87a4 100644 > > --- a/drivers/misc/mic/host/mic_boot.c > > +++ b/drivers/misc/mic/host/mic_boot.c > > @@ -137,7 +137,7 @@ static void *__mic_dma_alloc(struct device *dev, size_t size, > > struct scif_hw_dev *scdev = dev_get_drvdata(dev); > > struct mic_device *mdev = scdev_to_mdev(scdev); > > dma_addr_t tmp; > > - void *va = kmalloc(size, gfp | __GFP_ZERO); > > +void *va = kzalloc(size, gfp); > > Odd indation :( > > Always use checkpatch.pl on your patches to ensure you do not add new > problems. > > How did this get past 2 different people??? Sorry, didn't see the mail, it ended up in Junk. Thanks for catching it.