From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754110AbeAQVGJ (ORCPT ); Wed, 17 Jan 2018 16:06:09 -0500 Received: from anholt.net ([50.246.234.109]:41760 "EHLO anholt.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753593AbeAQVGH (ORCPT ); Wed, 17 Jan 2018 16:06:07 -0500 From: Eric Anholt To: dri-devel@lists.freedesktop.org Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH] drm/vc4: Flush the caches before the bin jobs, as well. In-Reply-To: <20171221221722.23809-1-eric@anholt.net> References: <20171221221722.23809-1-eric@anholt.net> User-Agent: Notmuch/0.22.2+1~gb0bcfaa (http://notmuchmail.org) Emacs/25.2.2 (x86_64-pc-linux-gnu) Date: Wed, 17 Jan 2018 13:06:04 -0800 Message-ID: <87vag0dwlf.fsf@anholt.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-=-= Content-Type: text/plain Eric Anholt writes: > If the frame samples from a render target that was just written, its > cache flush during the binning step may have occurred before the > previous frame's RCL was completed. Flush the texture caches again > before starting each RCL job to make sure that the sampling of the > previous RCL's output is correct. > > Fixes flickering in the top left of 3DMMES Taiji. > > Signed-off-by: Eric Anholt > Fixes: ca26d28bbaa3 ("drm/vc4: improve throughput by pipelining binning and rendering jobs") Whoops, in the subject, this should have been "before the *render* jobs." --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEE/JuuFDWp9/ZkuCBXtdYpNtH8nugFAlpfurwACgkQtdYpNtH8 nugbdA/8DdGvpvVzlEpIShNDJwKjoMmYUBj/4rFXDSizZuxrqNQnqVtqR5Ot7QQx IqlC+j3JtQmHdnhBD/fnJ7h/1Fp8e/IWn3m2iHMEysLCoqukIXGbHYy8bk+C6GXh 2ktiLaIxCcP/VuulKEvfk2fCgzGljxruvx5Fg30Zg1mmW67rwfVSZNJpf2ITR2IL dyA0YCvFJKmHuCl8zemVTqsndzqw5Az/RV7i4mjRlOE8i5o5rFPKRVk9H6LMDvgu zXXxR/UxTRmH76QAi47uP3qqEFIcp679HRCtqTsBJpE/qiyxo0G6c5RkBPQgeM6/ C3Q8J6qDfIRqz1+3qlH8WUwDxlsXDBVM1BATso0p2gt19UHMmyZ0d+YyGVzycOTg /hfkWtjsYzbjfYxnqJCVXEKUjQ/VEzJfkTKuI9GuLeNEdNZeDTAAaseET9NlElFq NeiC3YLDqAgHz6YCDv9ejl9w+nADfYXSQB4CPQnI8aPktckGDYLpQKUAobXPVy9N 6ONVLDqsEmVtz2LoVPWLb27tyqVfhutFbX8mf3myP7YmNuTp+JyV/VC9Sf89XdES mVWsALPlG1naxR2YRY12uzvxV9C0pXaVElTx0Ph8c6GmT2RP1S2XcXmPfmdtI4pj dl+uBUzyw3Fv5p7IdqCwCW2QyvXJJILZ9AjkxdPEjsbJZfLGdE8= =mTfa -----END PGP SIGNATURE----- --=-=-=--