public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Vitaly Kuznetsov <vkuznets@redhat.com>
To: Olaf Hering <olaf@aepfle.de>
Cc: kys@microsoft.com, gregkh@linuxfoundation.org,
	linux-kernel@vger.kernel.org, devel@linuxdriverproject.org
Subject: Re: move hyperv CHANNELMSG_UNLOAD from crashed kernel to kdump kernel
Date: Thu, 15 Dec 2016 15:32:29 +0100	[thread overview]
Message-ID: <87vaul2rgi.fsf@vitty.brq.redhat.com> (raw)
In-Reply-To: <20161215135111.GD6336@aepfle.de> (Olaf Hering's message of "Thu, 15 Dec 2016 14:51:12 +0100")

Olaf Hering <olaf@aepfle.de> writes:

> On Thu, Dec 15, Vitaly Kuznetsov wrote:
>
>> vmbus_wait_for_unload() may be receiving a message (not necessarily the
>> CHANNELMSG_UNLOAD_RESPONSE, we may see some other message) on the same
>> CPU it runs and in this case wrmsrl() makes sense. In other cases it
>> does nothing (neither good nor bad).
>
> If that other cpu has interrupts disabled it may not process a pending
> msg (the response may be stuck in the host queue?), and the loop can not
> kick the other cpus queue if a wrmsrl is just valid for the current cpu.
> If thats true, the response will not arrive in the loop.
>

In case interrupts get permanently disabled on the CPU which is supposed
to receive the CHANNELMSG_UNLOAD_RESPONSE message *and* there is some
other message pedning in the slot for that CPU we'll hang. We may try to
overcome this by sending NMIs but this is getting more and more
complicated...

I'd like to see a simple fix from Hyper-V host team: always deliver
CHANNELMSG_UNLOAD_RESPONSE reply to the cpu which sent CHANNELMSG_UNLOAD
request. This would allow us to remove all the craziness.

-- 
  Vitaly

  reply	other threads:[~2016-12-15 14:32 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-07  8:51 move hyperv CHANNELMSG_UNLOAD from crashed kernel to kdump kernel Olaf Hering
2016-12-07 15:04 ` KY Srinivasan
2016-12-07 15:46   ` Olaf Hering
2016-12-07 16:10     ` KY Srinivasan
2016-12-07 16:19       ` Olaf Hering
2016-12-07 16:24         ` KY Srinivasan
2016-12-07 16:39           ` Olaf Hering
2016-12-07 18:11             ` KY Srinivasan
2016-12-15 10:26 ` Vitaly Kuznetsov
2016-12-15 10:34   ` Olaf Hering
2016-12-15 10:36     ` Olaf Hering
2016-12-15 10:54       ` Vitaly Kuznetsov
2016-12-15 10:54     ` Vitaly Kuznetsov
2016-12-15 12:51       ` Olaf Hering
2016-12-15 13:28         ` Vitaly Kuznetsov
2016-12-15 13:51           ` Olaf Hering
2016-12-15 14:32             ` Vitaly Kuznetsov [this message]
2016-12-16  0:51               ` KY Srinivasan
2016-12-15 15:16           ` Olaf Hering

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87vaul2rgi.fsf@vitty.brq.redhat.com \
    --to=vkuznets@redhat.com \
    --cc=devel@linuxdriverproject.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=kys@microsoft.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=olaf@aepfle.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox