From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S936122AbcJRPal (ORCPT ); Tue, 18 Oct 2016 11:30:41 -0400 Received: from smtp01.smtpout.orange.fr ([80.12.242.123]:34944 "EHLO smtp.smtpout.orange.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935242AbcJRPaa (ORCPT ); Tue, 18 Oct 2016 11:30:30 -0400 X-ME-Helo: belgarion X-ME-Auth: amFyem1pay5yb2JlcnRAb3JhbmdlLmZy X-ME-Date: Tue, 18 Oct 2016 17:30:22 +0200 X-ME-IP: 109.220.223.51 From: Robert Jarzmik To: Viresh Kumar Cc: Daniel Mack , Haojian Zhuang , Rob Herring , Mark Rutland , Rafael Wysocki , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org Subject: Re: [PATCH v2 2/4] ARM: dts: pxa: add pxa25x cpu operating points References: <1476561450-28407-1-git-send-email-robert.jarzmik@free.fr> <1476561450-28407-3-git-send-email-robert.jarzmik@free.fr> <20161018113944.GC11471@vireshk-i7> X-URL: http://belgarath.falguerolles.org/ Date: Tue, 18 Oct 2016 17:30:11 +0200 In-Reply-To: <20161018113944.GC11471@vireshk-i7> (Viresh Kumar's message of "Tue, 18 Oct 2016 17:09:44 +0530") Message-ID: <87vawp4qv0.fsf@belgarion.home> User-Agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/24.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Viresh Kumar writes: > On 15-10-16, 21:57, Robert Jarzmik wrote: >> Add the relevant data taken from the PXA 25x Electrical, Mechanical, and >> Thermal Specfication. This will be input data for cpufreq-dt driver. >> >> Signed-off-by: Robert Jarzmik >> --- >> arch/arm/boot/dts/pxa25x.dtsi | 25 +++++++++++++++++++++++++ >> 1 file changed, 25 insertions(+) >> >> diff --git a/arch/arm/boot/dts/pxa25x.dtsi b/arch/arm/boot/dts/pxa25x.dtsi >> index 0d1e012178c4..16b4e8bad4a5 100644 >> --- a/arch/arm/boot/dts/pxa25x.dtsi >> +++ b/arch/arm/boot/dts/pxa25x.dtsi >> @@ -89,4 +89,29 @@ >> clocks = <&clktimer>; >> status = "okay"; >> }; >> + >> + pxa250_opp_table: opp_table0 { >> + compatible = "operating-points-v2"; >> + >> + opp@99500 { > > We have been keeping the values in ^^^ same as the values present > below. Any specific reason for making it different here ? No, that's a good comment, I'll change that. I wrote this incrementaly, first the node, then the opp-hz. Then I realized that the source crystal, at 3.8684 MHz didn't provide a round 99.5 MHz core clock, but a 99.5328 MHz clock. Anyway, I'll change that ... let's say into opp@99533 in this case ? -- Robert