From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752237AbcJJK0n (ORCPT ); Mon, 10 Oct 2016 06:26:43 -0400 Received: from mga01.intel.com ([192.55.52.88]:45129 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751976AbcJJK0l (ORCPT ); Mon, 10 Oct 2016 06:26:41 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,324,1473145200"; d="asc'?scan'208";a="17982858" From: Felipe Balbi To: Juergen Gross , linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org Cc: gregkh@linuxfoundation.org, Juergen Gross Subject: Re: [PATCH] usb/gadget: use kasprintf() instead of open coding it In-Reply-To: <1476094677-15101-1-git-send-email-jgross@suse.com> References: <1476094677-15101-1-git-send-email-jgross@suse.com> Date: Mon, 10 Oct 2016 13:26:03 +0300 Message-ID: <87vax0wldw.fsf@linux.intel.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hi, Juergen Gross writes: > Signed-off-by: Juergen Gross I can't apply anything without a commit log. Sorry. > diff --git a/drivers/usb/gadget/composite.c b/drivers/usb/gadget/composit= e.c > index 32176f7..455efec 100644 > --- a/drivers/usb/gadget/composite.c > +++ b/drivers/usb/gadget/composite.c > @@ -2382,18 +2382,8 @@ EXPORT_SYMBOL_GPL(usb_composite_setup_continue); >=20=20 > static char *composite_default_mfr(struct usb_gadget *gadget) > { > - char *mfr; > - int len; > - > - len =3D snprintf(NULL, 0, "%s %s with %s", init_utsname()->sysname, > - init_utsname()->release, gadget->name); > - len++; > - mfr =3D kmalloc(len, GFP_KERNEL); > - if (!mfr) > - return NULL; > - snprintf(mfr, len, "%s %s with %s", init_utsname()->sysname, > - init_utsname()->release, gadget->name); > - return mfr; > + return kasprintf(GFP_KERNEL, "%s %s with %s", init_utsname()->sysname, > + init_utsname()->release, gadget->name); > } >=20=20 > void usb_composite_overwrite_options(struct usb_composite_dev *cdev, > --=20 > 2.6.6 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-usb" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html =2D-=20 balbi --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIcBAEBCAAGBQJX+2y7AAoJEMy+uJnhGpkGtk0P/3MDZA0s2xkVGrolFIY46F04 JgTG2LOqoK0Tf4py68HemoxeNVrZviiLtTdwXaObvx4Cfy3Aguj9XxRWmVwAGkyi fDHg6cSFt4RXhEU48hg2CgShJzb2jsuGLBijj9pz+CKgmE6dAL9mNzIKi99gE1BC wR+ybB7+XrZfh/vR8ACDJAchBdwSSS52sdytumY3Jnu49GKqR0citvFEAVHxyqFC 2Sz4XmLIWpvBTjYoJ1Y3BogMDtiDblGBWxPWTGT6IVNFJB4pzP66Gcca64reLoKE YscimiHC7cKVPbECsVmO5flTFqt6pMA32Y+zqKge1VU5NoBUmsmdzWEp/jGXaKUk VhCyewdwTMjkYCD3Yhe+fWCBcOmBo/lybTY/IeFrNacQ3KoUGQgc4CbQnVIw2ahh qohgnRcW1P6tOTdr5DljxRmaHTN9eeDdUh7nPNCs8pluUcori7LCjQYCFAvERNYD d+sxxVL2Nq0b2Yjui/sEo8JI3UXZF7vnavefd35O6kWpLJRWl85g8ISRFN3CA+Lp 2gwPnVzeKFB6ndSj61lShj5BGQ0kiDj68kItJuIhYZ3coG1sFUsqWN24zqqRRhCy uVQbseGbdPVH3NbceqtleZ6vb8EWf4HuL98bdxZxOA8Hib+/n1NCCz6D03jWB30u 9jId2zEnDML9q5GNYo7e =9fqE -----END PGP SIGNATURE----- --=-=-=--