public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	kernel@savoirfairelinux.com,
	"David S. Miller" <davem@davemloft.net>,
	Florian Fainelli <f.fainelli@gmail.com>
Subject: Re: [PATCH net-next 3/3] net: dsa: mv88e6xxx: make global2 code optional
Date: Fri, 02 Sep 2016 13:13:21 -0400	[thread overview]
Message-ID: <87vayens26.fsf@ketchup.mtl.sfl> (raw)
In-Reply-To: <20160902161148.GK16864@lunn.ch>

Hi Andrew,

Andrew Lunn <andrew@lunn.ch> writes:

>> What do you think?
>
> I think the probe() needs to fail with a very obvious error message
> saying you need to recompile your kernel with option XYZ enabled in
> order to support this switch, when the optional stuff is not
> optional...

I agree. Does the following snippet looks OK?


    #ifndef CONFIG_NET_DSA_MV88E6XXX_GLOBAL2
            if (mv88e6xxx_has(chip, MV88E6XXX_FLAG_GLOBAL2)) {
                    dev_err(chip->dev, "Missing support for Global 2 registers\n");
                    return -EOPNOTSUPP;
            }
    #endif /* CONFIG_NET_DSA_MV88E6XXX_GLOBAL2 */


Thanks,

        Vivien

  reply	other threads:[~2016-09-02 17:13 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-02 12:08 [PATCH net-next 0/3] net: dsa: mv88e6xxx: isolate Global2 support Vivien Didelot
2016-09-02 12:08 ` [PATCH net-next 1/3] net: dsa: mv88e6xxx: fix module naming Vivien Didelot
2016-09-02 12:08 ` [PATCH net-next 2/3] net: dsa: mv88e6xxx: move Global2 code Vivien Didelot
2016-09-02 12:08 ` [PATCH net-next 3/3] net: dsa: mv88e6xxx: make global2 code optional Vivien Didelot
2016-09-02 14:55   ` Andrew Lunn
2016-09-02 15:22     ` Vivien Didelot
2016-09-02 16:11       ` Andrew Lunn
2016-09-02 17:13         ` Vivien Didelot [this message]
2016-09-02 17:19           ` Andrew Lunn
2016-09-02 17:32             ` Vivien Didelot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87vayens26.fsf@ketchup.mtl.sfl \
    --to=vivien.didelot@savoirfairelinux.com \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=f.fainelli@gmail.com \
    --cc=kernel@savoirfairelinux.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox