From: Mathieu OTHACEHE <m.othacehe@gmail.com>
To: Johan Hovold <johan@kernel.org>
Cc: Mathieu OTHACEHE <m.othacehe@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: serial: ti_usb_3410_5052: add MOXA UPORT 11x0 support
Date: Tue, 03 May 2016 13:46:51 +0200 [thread overview]
Message-ID: <87vb2vnz2s.fsf@gmail.com> (raw)
In-Reply-To: <20160503081422.GC25025@localhost>
> No, I was trying to say that the we should not attempt to load a
> firmware on the "ti_usb-v%04x-p%04x.fw" format before loading the moxa
> firmware.
For MTS devices (mts_*.fw) and for devices using generic firmware (ti_3410.fw
and ti_5052.fw), ti_usb-v%04x-p%04x.fw loading is already failing.
So, I can patch the driver to request firmwares in this order :
1. VID dependant (MTS and MOXA now)
2. ti_usb-v%04x-p%04x.fw format
3. Generic firmware
But, for generic firmware users, ti_usb-v%04x-p%04x.fw loading will
still always fail ...
Or we can get rid of ti_usb-v%04x-p%04x.fw loading because no one has
defined a firmware with this format in linux-firmware repository ?
> No, that's just integer-division with rounding. Remember that the
> divisions above are integer divisions so the results are actually 96 and
> 8 as expected.
You're right, sorry !
Thank you,
Mathieu
next prev parent reply other threads:[~2016-05-03 11:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20160502180407.GA4330@gmail.com>
2016-05-02 18:37 ` [PATCH] usb: serial: ti_usb_3410_5052: add MOXA UPORT 11x0 support Mathieu OTHACEHE
2016-05-03 8:14 ` Johan Hovold
2016-05-03 11:46 ` Mathieu OTHACEHE [this message]
2016-05-04 7:40 ` Johan Hovold
2016-03-02 9:46 Mathieu OTHACEHE
2016-04-24 15:59 ` Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vb2vnz2s.fsf@gmail.com \
--to=m.othacehe@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox