From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932663AbcECLr0 (ORCPT ); Tue, 3 May 2016 07:47:26 -0400 Received: from mail-wm0-f65.google.com ([74.125.82.65]:35964 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932252AbcECLrY (ORCPT ); Tue, 3 May 2016 07:47:24 -0400 References: <20160502180407.GA4330@gmail.com> <20160502183715.GA4453@gmail.com> <20160503081422.GC25025@localhost> User-agent: mu4e 0.9.17; emacs 24.5.1 From: Mathieu OTHACEHE To: Johan Hovold Cc: Mathieu OTHACEHE , Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] usb: serial: ti_usb_3410_5052: add MOXA UPORT 11x0 support In-reply-to: <20160503081422.GC25025@localhost> Date: Tue, 03 May 2016 13:46:51 +0200 Message-ID: <87vb2vnz2s.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > No, I was trying to say that the we should not attempt to load a > firmware on the "ti_usb-v%04x-p%04x.fw" format before loading the moxa > firmware. For MTS devices (mts_*.fw) and for devices using generic firmware (ti_3410.fw and ti_5052.fw), ti_usb-v%04x-p%04x.fw loading is already failing. So, I can patch the driver to request firmwares in this order : 1. VID dependant (MTS and MOXA now) 2. ti_usb-v%04x-p%04x.fw format 3. Generic firmware But, for generic firmware users, ti_usb-v%04x-p%04x.fw loading will still always fail ... Or we can get rid of ti_usb-v%04x-p%04x.fw loading because no one has defined a firmware with this format in linux-firmware repository ? > No, that's just integer-division with rounding. Remember that the > divisions above are integer divisions so the results are actually 96 and > 8 as expected. You're right, sorry ! Thank you, Mathieu