From: Felipe Balbi <felipe.balbi@linux.intel.com>
To: Denys Vlasenko <dvlasenk@redhat.com>, Felipe Balbi <balbi@ti.com>
Cc: Denys Vlasenko <dvlasenk@redhat.com>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers/usb/gadget/udc/r8a66597-udc.c: Deinline pipe_change, save 2176 bytes
Date: Mon, 11 Apr 2016 11:26:02 +0300 [thread overview]
Message-ID: <87vb3oo8kl.fsf@intel.com> (raw)
In-Reply-To: <87k2k4pvp0.fsf@intel.com>
[-- Attachment #1: Type: text/plain, Size: 587 bytes --]
Hi again,
Felipe Balbi <felipe.balbi@linux.intel.com> writes:
> Denys Vlasenko <dvlasenk@redhat.com> writes:
>> This function compiles to 298 bytes of machine code, has ~10 callsites.
>
> fair enough
>
>> This is a USB 2.0 device, USB 2.0 is limited to 35 MB/s, so should be
>
> it's not limited to 35MB/sec, sorry. USB 2.0 has a theoretical maximum
> of 60MB/sec. But 44MB/sec is what people consider 'possible'. I've
> gotten to 41MB/sec with g_mas_storage gadget.
also, you need to break you commit log lines at 72 characters. Please,
fix and resend
--
balbi
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 818 bytes --]
prev parent reply other threads:[~2016-04-11 8:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-08 19:55 [PATCH] drivers/usb/gadget/udc/r8a66597-udc.c: Deinline pipe_change, save 2176 bytes Denys Vlasenko
2016-04-11 5:21 ` Felipe Balbi
2016-04-11 8:26 ` Felipe Balbi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vb3oo8kl.fsf@intel.com \
--to=felipe.balbi@linux.intel.com \
--cc=balbi@ti.com \
--cc=dvlasenk@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).