From: Felipe Balbi <balbi@kernel.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Bin Liu <b-liu@ti.com>, Felipe Balbi <balbi@ti.com>,
balbif@gmail.com, Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: rework CONFIG_USB_COMMON logic
Date: Thu, 04 Feb 2016 13:49:17 +0200 [thread overview]
Message-ID: <87vb64ofuq.fsf@ti.com> (raw)
In-Reply-To: <6169754.IJXY8FWj5l@wuerfel>
[-- Attachment #1: Type: text/plain, Size: 893 bytes --]
Hi Greg,
Arnd Bergmann <arnd@arndb.de> writes:
> The phy-am335x driver selects 'USB_COMMON', but all other drivers
> use 'depends on' for that symbol, and it depends on USB || USB_GADGET
> itself, which causes a Kconfig warning:
>
> warning: (AM335X_PHY_USB) selects USB_COMMON which has unmet direct dependencies (USB_SUPPORT && (USB || USB_GADGET))
>
> As suggested by Felipe Balbi, this turns the logic around, and makes
> 'USB_COMMON' selected by everything else that needs it, so we can
> remove the dependencies.
>
> Fixes: 59f042f644c5 ("usb: phy: phy-am335x: bypass first VBUS sensing for host-only mode")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
In case you wanna take this one directly to your queue, here's my Ack:
Acked-by: Felipe Balbi <balbi@kernel.org>
Let me know if you prefer that I take this through the gadget tree.
cheers
--
balbi
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 818 bytes --]
next prev parent reply other threads:[~2016-02-04 11:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-03 22:35 [PATCH] usb: rework CONFIG_USB_COMMON logic Arnd Bergmann
2016-02-04 6:39 ` Peter Chen
2016-02-04 8:20 ` Arnd Bergmann
2016-02-04 11:49 ` Felipe Balbi [this message]
-- strict thread matches above, loose matches on Subject: below --
2016-03-23 16:45 Arnd Bergmann
2016-03-30 10:31 ` Felipe Balbi
2016-03-30 13:53 ` Arnd Bergmann
2016-03-30 13:56 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vb64ofuq.fsf@ti.com \
--to=balbi@kernel.org \
--cc=arnd@arndb.de \
--cc=b-liu@ti.com \
--cc=balbi@ti.com \
--cc=balbif@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox