From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965913AbcBDLt4 (ORCPT ); Thu, 4 Feb 2016 06:49:56 -0500 Received: from mail-lb0-f177.google.com ([209.85.217.177]:36782 "EHLO mail-lb0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965791AbcBDLtZ (ORCPT ); Thu, 4 Feb 2016 06:49:25 -0500 From: Felipe Balbi To: Arnd Bergmann Cc: Bin Liu , Felipe Balbi , balbif@gmail.com, Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] usb: rework CONFIG_USB_COMMON logic In-Reply-To: <6169754.IJXY8FWj5l@wuerfel> References: <6169754.IJXY8FWj5l@wuerfel> User-Agent: Notmuch/0.21 (http://notmuchmail.org) Emacs/25.0.90.1 (x86_64-pc-linux-gnu) Date: Thu, 04 Feb 2016 13:49:17 +0200 Message-ID: <87vb64ofuq.fsf@ti.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hi Greg, Arnd Bergmann writes: > The phy-am335x driver selects 'USB_COMMON', but all other drivers > use 'depends on' for that symbol, and it depends on USB || USB_GADGET > itself, which causes a Kconfig warning: > > warning: (AM335X_PHY_USB) selects USB_COMMON which has unmet direct depen= dencies (USB_SUPPORT && (USB || USB_GADGET)) > > As suggested by Felipe Balbi, this turns the logic around, and makes > 'USB_COMMON' selected by everything else that needs it, so we can > remove the dependencies. > > Fixes: 59f042f644c5 ("usb: phy: phy-am335x: bypass first VBUS sensing for= host-only mode") > Signed-off-by: Arnd Bergmann In case you wanna take this one directly to your queue, here's my Ack: Acked-by: Felipe Balbi Let me know if you prefer that I take this through the gadget tree. cheers =2D-=20 balbi --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJWszq9AAoJEIaOsuA1yqREaYMP/RerRtmNl7scYeNQpaphqc3u 5TWACCXAHm1aMkZn84B/9k+Df86zeRnbMspDNQGOUbCXjvwPQIhDrth8cdOJNH1Z U4T28gqVfc3wfRsnf/8JJimS8zAskpIidrUj7ymuTKw0EEiKyWpTr9zUSX3c+HZT 38sswcedYMRu+08JxIGsf9ccI3RZdXRzS7R+MMhdTjW4UiuwhmFKUpmRf5tc7eG0 G4rHm5KBDgqaCS/L/MhQ6fDlNsEhaX68EOdI93cuqmn098M7KvQH1VBCewRNy8MV bJmSGYXH2/nYL0rK4NwMuqZVW7s0DPA2FRPSR6NbO8nnn1RDWjurYdUFGTIlvrvj ekuB78NJkAFBeTNrxzZsKHU7fnoznEXLagKnCdf23dLJuZn9Hr4NsD0zA64heHVq sMr2vdA4X2fhBx3uu+vFrytXODm8xoKSjh+pWTdPEpPhaq+nIoKBYy69JZfSU3Yp UK5oL6ZqTtgRK/0G0ttxIEJSslHaLTQUIWHU8JFxW3TSi5xO4zlt3OrcbFl9Y9WV 9kWdByibQ+9zxipaDzHnwDz8Zffn7aV/HoYaggP5YZeuWZIlXZOV7tIWvVC3T+Y5 UQgxsEnESLzkf++baFi/7FBqZ/Z/1U3VnwqOCoIQ5puOylREyw8XDGkqDtx3vz79 EduPR7COfIXUzC9fWLve =dTKD -----END PGP SIGNATURE----- --=-=-=--