From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754164AbbKWI7o (ORCPT ); Mon, 23 Nov 2015 03:59:44 -0500 Received: from mail-lf0-f54.google.com ([209.85.215.54]:32947 "EHLO mail-lf0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752495AbbKWI7n (ORCPT ); Mon, 23 Nov 2015 03:59:43 -0500 From: Rasmus Villemoes To: Andy Shevchenko Cc: Andrew Morton , linux-kernel@vger.kernel.org Subject: Re: [PATCH v1 3/7] test_hexdump: go through all possible lengths of buffer Organization: D03 References: <1447259718-19647-1-git-send-email-andriy.shevchenko@linux.intel.com> <1447259718-19647-4-git-send-email-andriy.shevchenko@linux.intel.com> <87twois3or.fsf@rasmusvillemoes.dk> <1448038684.31665.179.camel@linux.intel.com> X-Hashcash: 1:20:151123:andriy.shevchenko@linux.intel.com::mZmD9fqXZcgPp4TT:00000000000000000000000000000dVC X-Hashcash: 1:20:151123:akpm@linux-foundation.org::+8LE/NdSzl5ajLXN:0000000000000000000000000000000000000qht X-Hashcash: 1:20:151123:linux-kernel@vger.kernel.org::tVSHMEFfRMe8K2aX:0000000000000000000000000000000004i1j Date: Mon, 23 Nov 2015 09:59:40 +0100 In-Reply-To: <1448038684.31665.179.camel@linux.intel.com> (Andy Shevchenko's message of "Fri, 20 Nov 2015 18:58:04 +0200") Message-ID: <87vb8tyttv.fsf@rasmusvillemoes.dk> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Nov 20 2015, Andy Shevchenko wrote: > On Thu, 2015-11-19 at 11:07 +0100, Rasmus Villemoes wrote: >> >> >> Why keep the variable l when it is just a synonym for the new >> parameter buflen? It is quite confusing that you change some but not >> all occurrences of l to buflen. If you want to make the diff minimal >> but still have a descriptive parameter name, just keep the 'size_t l >> = >> buflen;' assignment and don't otherwise refer to buflen. But I think >> it's better to eliminate 'l' and just change everything to >> buflen. Don't mix the two approaches, though. > > Okay, I got it for the future, though the series is already in linux- > next, so do we really need to re-hack half of it because of that? Stuff in -next isn't set in stone. I'm pretty sure Andrew can replace one set of patches with another. Rasmus