From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752375AbbG3L5X (ORCPT ); Thu, 30 Jul 2015 07:57:23 -0400 Received: from mga02.intel.com ([134.134.136.20]:31753 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750774AbbG3L5W (ORCPT ); Thu, 30 Jul 2015 07:57:22 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.15,577,1432623600"; d="scan'208";a="773192212" From: Alexander Shishkin To: Peter Zijlstra Cc: Ingo Molnar , linux-kernel@vger.kernel.org, adrian.hunter@intel.com, x86@kernel.org, hpa@zytor.com, acme@infradead.org Subject: Re: [PATCH 1/3] perf/x86/intel/pt: Add new timing packet enables In-Reply-To: <20150730104046.GV19282@twins.programming.kicks-ass.net> References: <1437140050-23363-1-git-send-email-alexander.shishkin@linux.intel.com> <1437140050-23363-2-git-send-email-alexander.shishkin@linux.intel.com> <20150730104046.GV19282@twins.programming.kicks-ass.net> User-Agent: Notmuch/0.20.2 (http://notmuchmail.org) Emacs/24.4.1 (x86_64-pc-linux-gnu) Date: Thu, 30 Jul 2015 14:57:17 +0300 Message-ID: <87vbd1kgde.fsf@ashishki-desk.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Peter Zijlstra writes: > On Fri, Jul 17, 2015 at 04:34:08PM +0300, Alexander Shishkin wrote: >> +#define PT_CONFIG_MASK (RTIT_CTL_TSC_EN | \ >> + RTIT_CTL_DISRETC | \ >> + RTIT_CTL_CYCLEACC | \ >> + RTIT_CTL_MTC_EN | \ >> + RTIT_CTL_MTC_RANGE | \ >> + RTIT_CTL_CYC_THRESH | \ >> + RTIT_CTL_PSB_FREQ) >> > > #define RTIT_CTL_CYC (RTIT_CTL_CYCLEACC | \ > RTIT_CTL_CYC_THRESH | \ > RTIT_CTL_PSB_FREQ) PSB_FREQ is not, strictly speaking, related to cycle accurate mode. Both adjustable psb frequency and cycle accurate mode settings are enumerated with the same CPUID bit, but they really do different things unrelated to one another. >> + if (config & (RTIT_CTL_MTC_EN | RTIT_CTL_MTC_RANGE)) { > > if (config & RTIT_CTL_MTC) { > > Would that make sense? To me either way is fine. Want me to respin it? Regards, -- Alex