Re: [PATCH 2/2] perf top: Handle 'z' key for toggle zeroing samples in TUI

Stephane Eranian
2014-08-12T23:07:32Z

On Tue, Aug 12, 2014 at 10:16 AM, Namhyung Kim <namhyung@kernel.org> wrote:
> The perf top TUI lacks 'z' key support to toggle sample zeroing.
> Add it.
>
Works for me.
Tested-by: Stephane Eranian <eranian@google.com>

> Reported-by: Stephane Eranian <eranian@google.com>
> Signed-off-by: Namhyung Kim <namhyung@kernel.org>
> ---
> tools/perf/ui/browsers/hists.c | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/tools/perf/ui/browsers/hists.c b/tools/perf/ui/browsers/hists.c
> index 045c1e16ac59..381c085a41b8 100644
> --- a/tools/perf/ui/browsers/hists.c
> +++ b/tools/perf/ui/browsers/hists.c
> @@ -10,6 +10,7 @@
> #include "../../util/pstack.h"
> #include "../../util/sort.h"
> #include "../../util/util.h"
> +#include "../../util/top.h"
> #include "../../arch/common.h"
>
> #include "../browser.h"
> @@ -1530,6 +1531,7 @@ static int perf_evsel__hists_browse(struct perf_evsel *evsel, int nr_events,
> "P Print histograms to perf.hist.N\n"
> "t Zoom into current Thread\n"
> "V Verbose (DSO names in callchains, etc)\n"
> + "z Toggle zeroing of samples\n"
> "/ Filter symbol by name";
>
> if (browser == NULL)
> @@ -1630,6 +1632,13 @@ static int perf_evsel__hists_browse(struct perf_evsel *evsel, int nr_events,
> case 'F':
> symbol_conf.filter_relative ^= 1;
> continue;
> + case 'z':
> + if (!is_report_browser(hbt)) {
> + struct perf_top *top = hbt->arg;
> +
> + top->zero = !top->zero;
> + }
> + continue;
> case K_F1:
> case 'h':
> case '?':
> --
> 2.0.0
>