Re: [PATCH 17/22] perf tools: Add build and install plugins targets

[Namhyung Kim <namhyung@kernel.org>]

Hi Jiri,

On Mon, 25 Nov 2013 15:51:44 +0100, Jiri Olsa wrote:
> On Sat, Nov 23, 2013 at 12:27:48AM +0900, Namhyung Kim wrote:
>> 2013-11-21 (목), 12:01 +0100, Jiri Olsa:
>> > Adding 'plugins' target along with the libtraceevent.a,
>> > so plugins are built together with traceevent library.
>> > 
>> > Adding 'install-traceevent-plugins' Makefile install target,
>> > instructing perf to install plugins into:
>> >   $(HOME)/libexec/perf-core/traceevent/plugins
>> >     - if installed localy under $HOME
>> >   $(DESTDIR)/$(prefix)/$(perfexecdir)/traceevent/plugins
>> >     - if installed globally
>> 
>> [SNIP]
>> > --- a/tools/perf/config/Makefile
>> > +++ b/tools/perf/config/Makefile
>> > @@ -578,6 +578,7 @@ else
>> >  lib = lib
>> >  endif
>> >  libdir = $(prefix)/$(lib)
>> > +plugindir=$(perfexecdir)/traceevent/plugins
>> 
>> Hmm.. it puts traceevent plugins under the perf directory.  But I don't
>> think it's a good idea since libtraceevent can be used independently.
>> 
>> What about something like this?
>> 
>>   plugindir = $(perfexecdir)/../traceevent/plugins
>
> this is where trace-cmd stores them:
>
>   $(HOME)/.trace-cmd/plugins
>   $(prefix)/$(libdir)/trace-cmd/plugins
>
> but I guess we want global place to install plugins,
> the traceevent by default uses:
>
>   $(HOME)/.traceevent/plugins
>   $(prefix)/lib/traceevent/plugins
>
> How about that?

Looks good to me.

Thanks,
Namhyung