public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Rusty Russell <rusty@rustcorp.com.au>
To: Jean Delvare <khali@linux-fr.org>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] There is no /sys/parameters
Date: Mon, 03 Jun 2013 10:51:06 +0930	[thread overview]
Message-ID: <87vc5wt2f1.fsf@rustcorp.com.au> (raw)
In-Reply-To: <20130531091029.5c5074bc@endymion.delvare>

Jean Delvare <khali@linux-fr.org> writes:

> There is no such path as /sys/parameters, module parameters live in
> /sys/module/*/parameters.

Thanks, applied!

Cheers,
Rusty.

> Signed-off-by: Jean Delvare <khali@linux-fr.org>
> Cc: Rusty Russell <rusty@rustcorp.com.au>
> ---
>  include/linux/moduleparam.h |    2 +-
>  kernel/params.c             |    2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> --- linux-3.10-rc3.orig/include/linux/moduleparam.h	2013-04-29 02:36:01.000000000 +0200
> +++ linux-3.10-rc3/include/linux/moduleparam.h	2013-05-30 10:41:37.417314420 +0200
> @@ -439,7 +439,7 @@ extern struct kernel_param_ops param_ops
>  extern int param_set_copystring(const char *val, const struct kernel_param *);
>  extern int param_get_string(char *buffer, const struct kernel_param *kp);
>  
> -/* for exporting parameters in /sys/parameters */
> +/* for exporting parameters in /sys/module/.../parameters */
>  
>  struct module;
>  
> --- linux-3.10-rc3.orig/kernel/params.c	2013-05-13 15:27:49.883223693 +0200
> +++ linux-3.10-rc3/kernel/params.c	2013-05-30 10:43:40.411316243 +0200
> @@ -787,7 +787,7 @@ static void __init kernel_add_sysfs_para
>  }
>  
>  /*
> - * param_sysfs_builtin - add contents in /sys/parameters for built-in modules
> + * param_sysfs_builtin - add sysfs parameters for built-in modules
>   *
>   * Add module_parameters to sysfs for "modules" built into the kernel.
>   *
>
>
> -- 
> Jean Delvare

      reply	other threads:[~2013-06-03  2:32 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-31  7:10 [PATCH] There is no /sys/parameters Jean Delvare
2013-06-03  1:21 ` Rusty Russell [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87vc5wt2f1.fsf@rustcorp.com.au \
    --to=rusty@rustcorp.com.au \
    --cc=khali@linux-fr.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox