From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760001Ab3B0Bwc (ORCPT ); Tue, 26 Feb 2013 20:52:32 -0500 Received: from ozlabs.org ([203.10.76.45]:51151 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755403Ab3B0BwJ (ORCPT ); Tue, 26 Feb 2013 20:52:09 -0500 From: Rusty Russell To: Milos Vyletel , linux-kernel@vger.kernel.org Cc: virtualization@lists.linux-foundation.org, mst@redhat.com, Asias He Subject: Re: [PATCH] virtio-blk: emit udev event when device is resized In-Reply-To: <1361473348-7660-1-git-send-email-milos.vyletel@sde.cz> References: <1361473348-7660-1-git-send-email-milos.vyletel@sde.cz> User-Agent: Notmuch/0.14 (http://notmuchmail.org) Emacs/23.4.1 (i686-pc-linux-gnu) Date: Wed, 27 Feb 2013 11:07:20 +1030 Message-ID: <87vc9eegn3.fsf@rustcorp.com.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Milos Vyletel writes: > When virtio-blk device is resized from host (using block_resize from QEMU) emit > KOBJ_CHANGE uevent to notify guest about such change. This allows user to have > custom udev rules which would take whatever action if such event occurs. As a > proof of concept I've created simple udev rule that automatically resize > filesystem on virtio-blk device. > > ACTION=="change", KERNEL=="vd*", \ > ENV{RESIZE}=="1", \ > ENV{ID_FS_TYPE}=="ext[3-4]", \ > RUN+="/sbin/resize2fs /dev/%k" > ACTION=="change", KERNEL=="vd*", \ > ENV{RESIZE}=="1", \ > ENV{ID_FS_TYPE}=="LVM2_member", \ > RUN+="/sbin/pvresize /dev/%k" > > Signed-off-by: Milos Vyletel OK, I collapsed the event[] line as suggested by Asias, and applied this. Thanks, Rusty. From: Milos Vyletel Subject: virtio-blk: emit udev event when device is resized When virtio-blk device is resized from host (using block_resize from QEMU) emit KOBJ_CHANGE uevent to notify guest about such change. This allows user to have custom udev rules which would take whatever action if such event occurs. As a proof of concept I've created simple udev rule that automatically resize filesystem on virtio-blk device. ACTION=="change", KERNEL=="vd*", \ ENV{RESIZE}=="1", \ ENV{ID_FS_TYPE}=="ext[3-4]", \ RUN+="/sbin/resize2fs /dev/%k" ACTION=="change", KERNEL=="vd*", \ ENV{RESIZE}=="1", \ ENV{ID_FS_TYPE}=="LVM2_member", \ RUN+="/sbin/pvresize /dev/%k" Signed-off-by: Milos Vyletel Tested-by: Asias He Signed-off-by: Rusty Russell (minor simplification) diff --git a/drivers/block/virtio_blk.c b/drivers/block/virtio_blk.c index 8ad21a2..922bcb9 100644 --- a/drivers/block/virtio_blk.c +++ b/drivers/block/virtio_blk.c @@ -539,6 +539,7 @@ static void virtblk_config_changed_work(struct work_struct *work) struct virtio_device *vdev = vblk->vdev; struct request_queue *q = vblk->disk->queue; char cap_str_2[10], cap_str_10[10]; + char *envp[] = { "RESIZE=1", NULL }; u64 capacity, size; mutex_lock(&vblk->config_lock); @@ -568,6 +569,7 @@ static void virtblk_config_changed_work(struct work_struct *work) set_capacity(vblk->disk, capacity); revalidate_disk(vblk->disk); + kobject_uevent_env(&disk_to_dev(vblk->disk)->kobj, KOBJ_CHANGE, envp); done: mutex_unlock(&vblk->config_lock); }