Re: [RFC PATCH] mm: trace filemap add and del

Robert Jarzmik
2012-11-21T10:41:33Z

Hugh Dickins <hughd@google.com> writes:

> On Thu, 8 Nov 2012, Robert Jarzmik wrote:
>> --- a/mm/filemap.c
>> +++ b/mm/filemap.c
>> @@ -467,6 +471,7 @@ int add_to_page_cache_locked(struct page *page, struct address_space *mapping,
>> } else {
>> page->mapping = NULL;
>> /* Leave page->index set: truncation relies upon it */
>> + trace_mm_filemap_add_to_page_cache(page);
>> spin_unlock_irq(&mapping->tree_lock);
>> mem_cgroup_uncharge_cache_page(page);
>> page_cache_release(page);
>
> I doubt if you really want your tracepoint sited just in this error path.

Urghh ... a git rebase mystified me.
In my original code, that tracepoint was 5 lines above, before the previous
spin_unlock_irq(), in the if branch, not the else branch.

Well spotted, I'll fix that for patch V2.

Cheers.

--
Robert