[PATCH] module: Fix compile error for ref_module when CONFIG_MODULES is not set

[PATCH] module: Fix compile error for ref_module when CONFIG_MODULES is not set

[Barbaros Tokaoğlu]

ref_module function is not defined when CONFIG_MODULES is not set thus
it causes compile error when a module which is set to be built-in uses it.
This patch defines a dummy ref_module function when CONFIG_MODULES
is not set.

Signed-off-by: Barbaros Tokaoğlu <barbarost@gmail.com>
---
 include/linux/module.h |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)

diff --git a/include/linux/module.h b/include/linux/module.h
index fbcafe2..ba9a7d0 100644
--- a/include/linux/module.h
+++ b/include/linux/module.h
@@ -553,6 +553,11 @@ static inline void module_put(struct module *module)
 {
 }

+static inline int ref_module(struct module *a, struct module *b)
+{
+       return 0;
+}
+
 #define module_name(mod) "kernel"

 /* For kallsyms to ask for address resolution.  NULL means not found. */
--
1.7.5.4

Re: [PATCH] module: Fix compile error for ref_module when CONFIG_MODULES is not set

[Rusty Russell]

On Wed, 1 Aug 2012 20:57:07 +0300, Barbaros Tokaoğlu <barbarost@gmail.com> wrote:
> ref_module function is not defined when CONFIG_MODULES is not set thus
> it causes compile error when a module which is set to be built-in uses it.
> This patch defines a dummy ref_module function when CONFIG_MODULES
> is not set.
> 
> Signed-off-by: Barbaros Tokaoğlu <barbarost@gmail.com>

Hi Barbaros,

        It's usually a good idea to paste the error message into the
commit message for compile fixes: it helps people googling the problem.

In this case, it's particularly important, because I can't find any
users of ref_module() outside module.c itself: it's only exported for
ksplice to use.

Cheers,
Rusty.

Re: [PATCH] module: Fix compile error for ref_module when CONFIG_MODULES is not set

[Barbaros Tokaoğlu]

Hi Rusty,

You are right, this was not for something in the kernel. I needed
ref_module to add some sort of dynamic dependency between modules but
this caused compile error when CONFIG_MODULES is not set. Another
option was using #ifdef CONFIG_MODULES check but the way in the patch
seemed correct to me.

However, if ref_module is exported only for ksplice, then you can
ignore this patch.

Thanks,
Barbaros

On Aug 6, 2012, at 9:58 AM, Rusty Russell <rusty@rustcorp.com.au> wrote:

> On Wed, 1 Aug 2012 20:57:07 +0300, Barbaros Tokaoğlu <barbarost@gmail.com> wrote:
>> ref_module function is not defined when CONFIG_MODULES is not set thus
>> it causes compile error when a module which is set to be built-in uses it.
>> This patch defines a dummy ref_module function when CONFIG_MODULES
>> is not set.
>>
>> Signed-off-by: Barbaros Tokaoğlu <barbarost@gmail.com>
>
> Hi Barbaros,
>
>       It's usually a good idea to paste the error message into the
> commit message for compile fixes: it helps people googling the problem.
>
> In this case, it's particularly important, because I can't find any
> users of ref_module() outside module.c itself: it's only exported for
> ksplice to use.
>
> Cheers,
> Rusty.