public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Rusty Russell <rusty@ozlabs.org>
To: Dmitry Antipov <dmitry.antipov@linaro.org>,
	Andrew Morton <akpm@linux-foundation.org>
Cc: Rusty Russell <rusty.russell@linaro.org>,
	linux-kernel@vger.kernel.org, linaro-dev@lists.linaro.org,
	patches@linaro.org, Dmitry Antipov <dmitry.antipov@linaro.org>
Subject: Re: [PATCH] module: debugging check for runaway kthreads
Date: Thu, 01 Mar 2012 12:06:54 +1030	[thread overview]
Message-ID: <87vcmp14qx.fsf@rustcorp.com.au> (raw)
In-Reply-To: <1330528873-7738-1-git-send-email-dmitry.antipov@linaro.org>

On Wed, 29 Feb 2012 19:21:13 +0400, Dmitry Antipov <dmitry.antipov@linaro.org> wrote:
> Debugging option CONFIG_MODULE_KTHREAD_CHECK provides a way to check
> whether all kernel threads created by the module and have used module
> code as a thread worker function are really exited when the module is
> unloaded. The following pseudo-code contains example of an error which
> is likely to be catched with this debugging check:

Nice idea, but that's 101 lines of code, for very little gain.

How about a debug option which unmaps all module pages on removal,
and ensures they don't get reused?  That might catch a multitude of
problems.  And yes, I realize it might be a bigger patch...

Thanks,
Rusty.

  reply	other threads:[~2012-03-01  1:38 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-29 15:21 [PATCH] module: debugging check for runaway kthreads Dmitry Antipov
2012-03-01  1:36 ` Rusty Russell [this message]
  -- strict thread matches above, loose matches on Subject: below --
2012-02-03  6:37 Dmitry Antipov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87vcmp14qx.fsf@rustcorp.com.au \
    --to=rusty@ozlabs.org \
    --cc=akpm@linux-foundation.org \
    --cc=dmitry.antipov@linaro.org \
    --cc=linaro-dev@lists.linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=patches@linaro.org \
    --cc=rusty.russell@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox