public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: JJ Ding <jj_ding@emc.com.tw>
To: Seth Forshee <seth.forshee@canonical.com>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
	"Dmitry Torokhov" <dmitry.torokhov@gmail.com>,
	"Aaron Huang" <aaron_huang@emc.com.tw>,
	"Tom Lin" <tom_lin@emc.com.tw>,
	"Éric Piel" <E.A.B.Piel@tudelft.nl>,
	"Daniel Kurtz" <djkurtz@chromium.org>,
	"Chase Douglas" <chase.douglas@canonical.com>,
	"Henrik Rydberg" <rydberg@euromail.se>,
	"Alessandro Rubini" <rubini@cvml.unipv.it>
Subject: Re: [PATCH v3 7/7] Input: elantech - add v3 hardware support
Date: Mon, 29 Aug 2011 15:16:16 +0800	[thread overview]
Message-ID: <87vctgsn5r.fsf@emc.com.tw> (raw)
In-Reply-To: <20110826142813.GB13381@thinkpad-t410>

On Fri, 26 Aug 2011 09:28:13 -0500, Seth Forshee <seth.forshee@canonical.com> wrote:
> On Fri, Aug 26, 2011 at 09:03:11AM +0800, JJ Ding wrote:
> > +	/*
> > +	 * check debounce first, it has the same signature in byte 0 
> 
> Just one pedantic comment -- git complained about trailing whitespace on
> this line. Not that important, and Dmitry can clean it up when he
> applies the patch if he's so inclined.
> 
> This patch looks good now, and it's testing fine for me.
> 
> Reviewed-and-Tested-by: Seth Forshee <seth.forshee@canonical.com>
Thank you very much for viewing and testing this code, Seth.
> 
> I'm also curious what you found out about whether or not the touchpad
> does accurate finger tracking. I've played with it a little, and the
> finger tracking has been accurate except for one small exception. When
> the fingers are overlapping on one axis the touchpad always reports the
> same position for both fingers along that axis. For instance, if I move
> one finger up and the other finger down simultaneously on the touchpad,
> one of the fingers will show reverse movement on the y axis briefly
> while the fingers overlap. But I've never seen the fingers swap between
> the two frames of the packet.
I just got confirmed that with v3, two finger touch always gets reported
separately. I will resend this series for this update.
Add what you observed is actually hardware limitation. The v3 hardware
only has a projective sensor. When two fingers are overlapping along x or
y axis, the hardware can only sense one on that axis, once the two
fingers are away from the "crossing zone", they get reported separately again.

jj
> --
> To unsubscribe from this list: send the line "unsubscribe linux-input" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

      reply	other threads:[~2011-08-29  7:14 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-26  1:03 [PATCH v3 0/7] Input: elantech: add support for newer hardware JJ Ding
2011-08-26  1:03 ` [PATCH v3 1/7] Input: elantech - correct x, y value range for v2 hardware JJ Ding
2011-08-26  1:03 ` [PATCH v3 2/7] Input: elantech - get rid of ETP_2FT_* in elantech.h JJ Ding
2011-08-26  1:03 ` [PATCH v3 3/7] Input: elantech - use firmware provided x, y ranges JJ Ding
2011-08-26  1:03 ` [PATCH v3 4/7] Input: elantech - remove ETP_EDGE_FUZZ_V2 JJ Ding
2011-08-26  1:03 ` [PATCH v3 5/7] Input: elantech - packet checking for v2 hardware JJ Ding
2011-08-26  1:03 ` [PATCH v3 6/7] Input: elantech - clean up elantech_init JJ Ding
2011-08-26  1:03 ` [PATCH v3 7/7] Input: elantech - add v3 hardware support JJ Ding
2011-08-26 14:28   ` Seth Forshee
2011-08-29  7:16     ` JJ Ding [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87vctgsn5r.fsf@emc.com.tw \
    --to=jj_ding@emc.com.tw \
    --cc=E.A.B.Piel@tudelft.nl \
    --cc=aaron_huang@emc.com.tw \
    --cc=chase.douglas@canonical.com \
    --cc=djkurtz@chromium.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rubini@cvml.unipv.it \
    --cc=rydberg@euromail.se \
    --cc=seth.forshee@canonical.com \
    --cc=tom_lin@emc.com.tw \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox