From: Kevin Hilman <khilman@ti.com>
To: Thomas Weber <thomas.weber.linux@googlemail.com>
Cc: Govindraj <govindraj.ti@gmail.com>,
Thomas Weber <weber@corscience.de>,
linux-omap@vger.kernel.org, manjugk@ti.com, gadiyar@ti.com,
tony@atomide.com, govindraj@ti.com, gregkh@suse.de,
andrei.emeltchenko@nokia.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCHv3] OMAP: Enable Magic SysRq on serial console ttyOx
Date: Mon, 31 Jan 2011 15:54:11 -0800 [thread overview]
Message-ID: <87vd141vfg.fsf@ti.com> (raw)
In-Reply-To: <AANLkTi=HxnPVu83CpodFA4rLipcz1Oie2co49S1=+1M6@mail.gmail.com> (Thomas Weber's message of "Mon, 31 Jan 2011 22:31:09 +0100")
Thomas Weber <thomas.weber.linux@googlemail.com> writes:
> On Mon, Jan 24, 2011 at 10:47 PM, Kevin Hilman <khilman@ti.com> wrote:
>> Govindraj <govindraj.ti@gmail.com> writes:
>>
>>> On Fri, Jan 21, 2011 at 3:31 PM, Thomas Weber <weber@corscience.de> wrote:
>>>> Magic SysRq key is not working for OMAP on new serial
>>>> console ttyOx because SUPPORT_SYSRQ is not defined
>>>> for omap-serial.
>>>>
>>>> This patch defines SUPPORT_SYSRQ in omap-serial and
>>>> enables handling of Magic SysRq character.
>>>>
>>>> Further there is an issue of losing first break character.
>>>> Removing the reset of the lsr_break_flag fixes this issue.
>>>>
>>>> Signed-off-by: Thomas Weber <weber@corscience.de>
>>>
>>>
>>> Acked-by: Govindraj.R <govindraj.raja@ti.com>
>>> Tested-by: Manjunath G Kondaiah <manjugk@ti.com>
>>>
>>
>> Acked-by: Kevin Hilman <khilman@ti.com>
>>
>> Greg, this one should go for .38-rc. Feel free to merge, or we can
>> take it through the OMAP tree with your ack.
>>
>> Thanks,
>>
>> Kevin
>>
>> --
>
> Hello,
> should I rebase this patch, because it does not apply after movement
> of driver/serial to driver/tty/serial?
>
Yes, please rebase.
Thanks,
Kevin
prev parent reply other threads:[~2011-01-31 23:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-21 10:01 [PATCHv3] OMAP: Enable Magic SysRq on serial console ttyOx Thomas Weber
2011-01-21 10:12 ` Govindraj
2011-01-24 21:47 ` Kevin Hilman
2011-01-31 21:31 ` Thomas Weber
2011-01-31 23:54 ` Kevin Hilman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vd141vfg.fsf@ti.com \
--to=khilman@ti.com \
--cc=andrei.emeltchenko@nokia.com \
--cc=gadiyar@ti.com \
--cc=govindraj.ti@gmail.com \
--cc=govindraj@ti.com \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=manjugk@ti.com \
--cc=thomas.weber.linux@googlemail.com \
--cc=tony@atomide.com \
--cc=weber@corscience.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox