Re: [PATCH v3 1/2] Add function to convert between calendar time and broken-down time for universal use

[OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>]

Zhaolei <zhaolei@cn.fujitsu.com> writes:

> There is no users of printk("%pf"), why not remove this?

IMO, because it doesn't make slow thing.

> And at least, I found one: drivers/char/efirtc.c
> If I continue searching, maybe more.

If there is a user, I think it's ok.

> IHMO, user of these functions should understand what these functions is and
> use these functions for right way.
> If we give user a cdrom, it is user's responsibility not using is as cup stand.
>
> At least, there function can make following source a fairy:
> fs/ncpfs/dir.c
> fs/smbfs/proc.c
> fs/fat/misc.c
> fs/udf/udftime.c
> fs/cifs/netmisc.c
> net/netfilter/xt_time.c
> drivers/scsi/ips.c
> ...
>
> It is different with user-land just because it lakes of large-complex locale
> database.

Yes, and I'm understanding FAT has the bug, and there is actual bug
report (bug FAT requires this as on-disk format). However, my point is
why we increase the known bugs.

>> gmtime() also need to handle timezone actually.
>
> So, maybe another function name as unmktime?

Maybe. Um..., or time_to_tm()? I'm not sure.

Thanks.
-- 
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>