[PATCH, resend] i386: also limit NODES_HIGH_SHIFT here

[PATCH, resend] i386: also limit NODES_HIGH_SHIFT here

[Jan Beulich]

Impact: configuration bug fix

Just like for x86-64, the range of widths valid for NODE_SHIFT is not
unbounded. The upper bound 64-bit uses is definitely also an upper
bound for 32-bit.

Signed-off-by: Jan Beulich <jbeulich@novell.com>

---
 arch/x86/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- linux-2.6.29-rc7/arch/x86/Kconfig	2009-03-04 09:10:19.000000000 +0100
+++ 2.6.29-rc7-i386-nodes-shift-limit/arch/x86/Kconfig	2009-03-06 10:24:22.000000000 +0100
@@ -1087,7 +1087,7 @@ config NUMA_EMU
 
 config NODES_SHIFT
 	int "Maximum NUMA Nodes (as a power of 2)" if !MAXSMP
-	range 1 9   if X86_64
+	range 1 9
 	default "9" if MAXSMP
 	default "6" if X86_64
 	default "4" if X86_NUMAQ

Re: [PATCH, resend] i386: also limit NODES_HIGH_SHIFT here

[Andi Kleen]

"Jan Beulich" <jbeulich@novell.com> writes:

> Impact: configuration bug fix
>
> Just like for x86-64, the range of widths valid for NODE_SHIFT is not
> unbounded. The upper bound 64-bit uses is definitely also an upper
> bound for 32-bit.

I think that's actually obsolete, there's no real 128 nodes limit.

The only limit used to be 256 nodes because you can't have more nodes
than CPUs, but that's obsolete with x2apic.

-Andi

-- 
ak@linux.intel.com -- Speaking for myself only.

[tip:x86/mm] x86, 32-bit: also limit NODES_HIGH_SHIFT here

[Jan Beulich]

Commit-ID:  46d50c98d90cd7feaa5977a09c574063e5c99b3d
Gitweb:     http://git.kernel.org/tip/46d50c98d90cd7feaa5977a09c574063e5c99b3d
Author:     Jan Beulich <jbeulich@novell.com>
AuthorDate: Thu, 12 Mar 2009 12:33:06 +0000
Commit:     Ingo Molnar <mingo@elte.hu>
CommitDate: Fri, 13 Mar 2009 02:37:17 +0100

x86, 32-bit: also limit NODES_HIGH_SHIFT here

Impact: configuration bug fix

Just like for x86-64, the range of widths valid for NODE_SHIFT is not
unbounded. The upper bound 64-bit uses is definitely also an upper
bound for 32-bit.

Signed-off-by: Jan Beulich <jbeulich@novell.com>
LKML-Reference: <49B90F12.76E4.0078.0@novell.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>


---
 arch/x86/Kconfig |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
index 87717f3..076f4f8 100644
--- a/arch/x86/Kconfig
+++ b/arch/x86/Kconfig
@@ -1123,7 +1123,7 @@ config NUMA_EMU
 
 config NODES_SHIFT
 	int "Maximum NUMA Nodes (as a power of 2)" if !MAXSMP
-	range 1 9   if X86_64
+	range 1 9
 	default "9" if MAXSMP
 	default "6" if X86_64
 	default "4" if X86_NUMAQ