From: Markus Armbruster <armbru@redhat.com>
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"xen-devel\@lists.xensource.com" <xen-devel@lists.xensource.com>,
Anders Kaseorg <andersk@MIT.EDU>
Subject: Re: [Xen-devel] Re: [PATCH] IRQ handling race and spurious IIR read in serial/8250.c
Date: Thu, 19 Feb 2009 19:37:53 +0100 [thread overview]
Message-ID: <87vdr6z30e.fsf@pike.pond.sub.org> (raw)
In-Reply-To: <18845.40059.190188.291643@mariner.uk.xensource.com> (Ian Jackson's message of "Thu\, 19 Feb 2009 17\:52\:59 +0000")
Ian Jackson <Ian.Jackson@eu.citrix.com> writes:
> I wrote:
>> In drivers/serial/8250.c in Linux there are two bugs:
>> 1. UART_BUG_TXEN can be spuriously set, due to an IRQ race
>> 2. The workaround then applied by the kernel is itself buggy
>
> Markus Armbruster has also experienced this problem in a Xen
> environment and has confirmed that my patch fixes it.
Correct.
> I think at the very least this change:
>
>> Proposed initial band-aid fix (against 2.6.28.4):
>>
>> Do not read IIR in serial8250_start_tx when UART_BUG_TXEN
>>
>> Reading the IIR clears some oustanding interrupts so it is not safe.
>> Instead, simply transmit immediately if the buffer is empty without
>> regard to IIR.
>>
>> Signed-off-by: Ian Jackson <ian.jackson@eu.citrix.com>
>
> should be made right away.
>
> Ian.
Patch makes sense to me.
Acked-by: Markus Armbruster <armbru@redhat.com>
next prev parent reply other threads:[~2009-02-19 18:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1233800599.5398.0.camel@balanced-tree>
[not found] ` <18827.7191.646173.99255@mariner.uk.xensource.com>
[not found] ` <1233862446.5676.28.camel@balanced-tree>
[not found] ` <1233870772.5676.40.camel@balanced-tree>
[not found] ` <18833.40557.119090.48930@mariner.uk.xensource.com>
[not found] ` <alpine.DEB.2.00.0902101249181.20723@vinegar-pot.mit.edu>
2009-02-11 16:08 ` [PATCH] IRQ handling race and spurious IIR read in serial/8250.c Ian Jackson
2009-02-19 17:52 ` Ian Jackson
2009-02-19 18:37 ` Markus Armbruster [this message]
2009-02-19 19:24 ` Jeremy Fitzhardinge
2009-03-12 17:57 Markus Armbruster
2009-03-12 18:09 ` Alan Cox
2009-03-12 19:30 ` Ian Jackson
2009-03-12 21:38 ` [Xen-devel] " Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vdr6z30e.fsf@pike.pond.sub.org \
--to=armbru@redhat.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=andersk@MIT.EDU \
--cc=linux-kernel@vger.kernel.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox