[PATCH] x86: revert CONFIG_RELOCATABLE=y defconfig change

[PATCH] x86: revert CONFIG_RELOCATABLE=y defconfig change

[Vegard Nossum]

>From 37a92bc970ce025d8a42fed27413485fd341db31 Mon Sep 17 00:00:00 2001
From: Vegard Nossum <vegard.nossum@gmail.com>
Date: Thu, 18 Dec 2008 18:03:20 +0100
Subject: [PATCH] x86: revert CONFIG_RELOCATABLE=y defconfig change

This commit:

commit 5cb04df8d3f03e37a19f2502591a84156be71772
Author: Ingo Molnar <mingo@elte.hu>
Date:   Sun May 4 19:49:04 2008 +0200

   x86: defconfig updates

changed CONFIG_RELOCATABLE from n to y, which may lead to a mismatch
between the vmlinux debug information and the runtime location of the
kernel, even when the bootloader does not relocate the kernel.

Revert the specific change. Works for me with GRUB and qemu.

Reference: http://lkml.org/lkml/2008/11/25/243

Cc: Huang Ying <ying.huang@intel.com>
Cc: "H. Peter Anvin" <hpa@zytor.com>
Signed-off-by: Vegard Nossum <vegard.nossum@gmail.com>
---
 arch/x86/configs/i386_defconfig   |    2 +-
 arch/x86/configs/x86_64_defconfig |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/x86/configs/i386_defconfig b/arch/x86/configs/i386_defconfig
index 13b8c86..488cafc 100644
--- a/arch/x86/configs/i386_defconfig
+++ b/arch/x86/configs/i386_defconfig
@@ -298,7 +298,7 @@ CONFIG_KEXEC=y
 CONFIG_CRASH_DUMP=y
 # CONFIG_KEXEC_JUMP is not set
 CONFIG_PHYSICAL_START=0x1000000
-CONFIG_RELOCATABLE=y
+# CONFIG_RELOCATABLE is not set
 CONFIG_PHYSICAL_ALIGN=0x200000
 CONFIG_HOTPLUG_CPU=y
 # CONFIG_COMPAT_VDSO is not set
diff --git a/arch/x86/configs/x86_64_defconfig b/arch/x86/configs/x86_64_defconfig
index f0a03d7..4327bba 100644
--- a/arch/x86/configs/x86_64_defconfig
+++ b/arch/x86/configs/x86_64_defconfig
@@ -298,7 +298,7 @@ CONFIG_SCHED_HRTICK=y
 CONFIG_KEXEC=y
 CONFIG_CRASH_DUMP=y
 CONFIG_PHYSICAL_START=0x1000000
-CONFIG_RELOCATABLE=y
+# CONFIG_RELOCATABLE is not set
 CONFIG_PHYSICAL_ALIGN=0x200000
 CONFIG_HOTPLUG_CPU=y
 # CONFIG_COMPAT_VDSO is not set
-- 
1.5.6.5

Re: [PATCH] x86: revert CONFIG_RELOCATABLE=y defconfig change

[Ingo Molnar]

* Vegard Nossum <vegard.nossum@gmail.com> wrote:

> >From 37a92bc970ce025d8a42fed27413485fd341db31 Mon Sep 17 00:00:00 2001
> From: Vegard Nossum <vegard.nossum@gmail.com>
> Date: Thu, 18 Dec 2008 18:03:20 +0100
> Subject: [PATCH] x86: revert CONFIG_RELOCATABLE=y defconfig change
> 
> This commit:
> 
> commit 5cb04df8d3f03e37a19f2502591a84156be71772
> Author: Ingo Molnar <mingo@elte.hu>
> Date:   Sun May 4 19:49:04 2008 +0200
> 
>    x86: defconfig updates
> 
> changed CONFIG_RELOCATABLE from n to y, which may lead to a mismatch
> between the vmlinux debug information and the runtime location of the
> kernel, even when the bootloader does not relocate the kernel.
> 
> Revert the specific change. Works for me with GRUB and qemu.
> 
> Reference: http://lkml.org/lkml/2008/11/25/243
> 
> Cc: Huang Ying <ying.huang@intel.com>
> Cc: "H. Peter Anvin" <hpa@zytor.com>
> Signed-off-by: Vegard Nossum <vegard.nossum@gmail.com>
> ---
>  arch/x86/configs/i386_defconfig   |    2 +-
>  arch/x86/configs/x86_64_defconfig |    2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)

applied to tip/x86/defconfig, thanks Vegard!

	Ingo

Re: [PATCH] x86: revert CONFIG_RELOCATABLE=y defconfig change

[Andi Kleen]

Vegard Nossum <vegard.nossum@gmail.com> writes:

> From 37a92bc970ce025d8a42fed27413485fd341db31 Mon Sep 17 00:00:00 2001
> From: Vegard Nossum <vegard.nossum@gmail.com>
> Date: Thu, 18 Dec 2008 18:03:20 +0100
> Subject: [PATCH] x86: revert CONFIG_RELOCATABLE=y defconfig change
>
> This commit:
>
> commit 5cb04df8d3f03e37a19f2502591a84156be71772
> Author: Ingo Molnar <mingo@elte.hu>
> Date:   Sun May 4 19:49:04 2008 +0200
>
>    x86: defconfig updates
>
> changed CONFIG_RELOCATABLE from n to y, which may lead to a mismatch
> between the vmlinux debug information and the runtime location of the
> kernel, even when the bootloader does not relocate the kernel.
>
> Revert the specific change. Works for me with GRUB and qemu.
>
> Reference: http://lkml.org/lkml/2008/11/25/243

it would be better to find some way to fix up the debug information
(perhaps this can be done with the right ld parameters?)

Changing defconfig doesn't really fix the problem because there will
be still lots of kernel configurations around with
CONFIG_RELOCATABLE=y

-Andi

-- 
ak@linux.intel.com

Re: [PATCH] x86: revert CONFIG_RELOCATABLE=y defconfig change

[H. Peter Anvin]

Andi Kleen wrote:
> 
> it would be better to find some way to fix up the debug information
> (perhaps this can be done with the right ld parameters?)
> 
> Changing defconfig doesn't really fix the problem because there will
> be still lots of kernel configurations around with
> CONFIG_RELOCATABLE=y
> 

Fixing the debug information is definitely necessary.  This is merely a
stopgap.  There has been a bug report about the relocatable kernel's
symbol information for a while, but there seems to be no forward
progress at fixing those.  I might end up taking a look at it.

	-hpa

-- 
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel.  I don't speak on their behalf.