From: Juergen Kreileder <jk@blackdown.de>
To: Andrew Morton <akpm@osdl.org>
Cc: Oleg Nesterov <oleg@tv-sign.ru>,
linux-kernel@vger.kernel.org, maneesh@in.ibm.com,
benh@kernel.crashing.org
Subject: Re: [PATCH] fix __mod_timer vs __run_timers deadlock.
Date: Tue, 03 May 2005 00:50:24 +0200 [thread overview]
Message-ID: <87vf61kztb.fsf@blackdown.de> (raw)
In-Reply-To: <20050501023149.6908c573.akpm@osdl.org> (Andrew Morton's message of "Sun, 1 May 2005 02:31:49 -0700")
Andrew Morton <akpm@osdl.org> writes:
> Oleg Nesterov <oleg@tv-sign.ru> wrote:
>>
>> When __mod_timer() changes timer's base it waits for the completion
>> of timer->function. It is just stupid: the caller of __mod_timer()
>> can held locks which would prevent completion of the timer's
>> handler.
>>
>> Solution: do not change the base of the currently running timer.
>
> OK, fingers crossed. Juergen, it would be great if you could test
> Oleg's patch sometime.
I had one more lockup yesterday but that probably was caused by
something else because Azureus is running fine for 24 hours now.
Thanks Oleg!
Juergen
--
Juergen Kreileder, Blackdown Java-Linux Team
http://blog.blackdown.de/
next prev parent reply other threads:[~2005-05-02 22:50 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-01 7:55 [PATCH] fix __mod_timer vs __run_timers deadlock Oleg Nesterov
2005-05-01 9:31 ` Andrew Morton
2005-05-02 22:50 ` Juergen Kreileder [this message]
2005-05-03 0:13 ` Benjamin Herrenschmidt
2005-05-03 1:24 ` Lee Revell
2005-05-03 1:28 ` Benjamin Herrenschmidt
2005-05-03 1:33 ` Zwane Mwaikambo
2005-05-03 1:35 ` Juergen Kreileder
2005-05-03 2:48 ` Paul Mackerras
2005-05-03 18:51 ` David S. Miller
2005-05-03 23:44 ` Benjamin Herrenschmidt
2005-05-03 23:39 ` David S. Miller
2005-05-04 0:05 ` Benjamin Herrenschmidt
2005-05-02 4:08 ` Maneesh Soni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vf61kztb.fsf@blackdown.de \
--to=jk@blackdown.de \
--cc=akpm@osdl.org \
--cc=benh@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maneesh@in.ibm.com \
--cc=oleg@tv-sign.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox