public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Hilko Bengen <bengen@hilluzination.de>
To: linux-kernel@vger.kernel.org
Cc: Marcelo Tosatti <marcelo.tosatti@cyclades.com>
Subject: Re: Linux 2.4.25-rc4
Date: Fri, 20 Feb 2004 00:28:23 +0100	[thread overview]
Message-ID: <87vfm2ps2w.fsf@hilluzination.de> (raw)
In-Reply-To: <Pine.LNX.4.58L.0402191639120.7378@logos.cnet> (Marcelo Tosatti's message of "Thu, 19 Feb 2004 16:39:39 -0300 (BRT)")

Marcelo Tosatti <marcelo.tosatti@cyclades.com> writes:

>> Ok, the bug has been there for ages and, being an ISA card, the
>> I-Surf is probably not used that much any more... Was there
>> anything wrong with the patch I sent?
>
> I dont think so. I will be in 2.4.26-pre1

Thanks.

There was also another patch which I posted earlier to this list. 

It fixes an issue with iomem being displayed wrong in /proc/isapnp
output. I found this when trying to debug the isurf issue.

Please include that also.

-Hilko

diff -uir orig/linux-2.4.23/drivers/pnp/isapnp_proc.c linux-2.4.24/drivers/pnp/isapnp_proc.c
--- orig/linux-2.4.23/drivers/pnp/isapnp_proc.c	2002-11-29 00:53:14.000000000 +0100
+++ linux-2.4.24/drivers/pnp/isapnp_proc.c	2004-02-06 14:56:45.000000000 +0100
@@ -649,7 +649,7 @@
 	if (next)
 		isapnp_printf(buffer, "\n");
 	for (i = next = 0; i < 4; i++) {
-		tmp = isapnp_read_dword(ISAPNP_CFG_MEM + (i << 3));
+		tmp = isapnp_read_word(ISAPNP_CFG_MEM + (i << 3)) << 8;
 		if (!tmp)
 			continue;
 		if (!next) {



      reply	other threads:[~2004-02-19 23:32 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-02-18  5:11 Linux 2.4.25-rc4 Marcelo Tosatti
2004-02-18  5:57 ` Willy Tarreau
2004-02-18 14:34   ` Marcelo Tosatti
2004-02-18 21:27     ` Willy Tarreau
2004-02-20 22:48     ` Pavel Machek
2004-02-22  8:41       ` Willy Tarreau
2004-02-22 22:03         ` Pavel Machek
2004-02-18 19:17 ` Hilko Bengen
2004-02-19 19:39   ` Marcelo Tosatti
2004-02-19 23:28     ` Hilko Bengen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87vfm2ps2w.fsf@hilluzination.de \
    --to=bengen@hilluzination.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcelo.tosatti@cyclades.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox