From: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
To: Martin Schwidefsky <schwidefsky@de.ibm.com>
Cc: linux-kernel@vger.kernel.org, torvalds@transmeta.com
Subject: Re: [PATCH] s390 (5/8): common i/o layer.
Date: Sat, 30 Aug 2003 04:25:21 +0900 [thread overview]
Message-ID: <87vfsggtb2.fsf@devron.myhome.or.jp> (raw)
In-Reply-To: <20030829171005.GF1242@mschwid3.boeblingen.de.ibm.com>
Martin Schwidefsky <schwidefsky@de.ibm.com> writes:
> --- linux-2.6/drivers/s390/cio/css.c Sat Aug 23 01:52:24 2003
> +++ linux-2.6-s390/drivers/s390/cio/css.c Fri Aug 29 18:55:10 2003
[...]
> @@ -97,8 +85,7 @@
> sch->dev.bus = &css_bus_type;
>
> /* Set a name for the subchannel */
> - strlcpy (sch->dev.name, subchannel_types[sch->st], DEVICE_NAME_SIZE);
> - snprintf (sch->dev.bus_id, DEVICE_ID_SIZE, "0:%04x", sch->irq);
> + snprintf (sch->dev.bus_id, DEVICE_ID_SIZE, "0.0.%04x", sch->irq);
>
> /* make it known to the system */
> ret = device_register(&sch->dev);
> diff -urN linux-2.6/drivers/s390/cio/device.c linux-2.6-s390/drivers/s390/cio/device.c
> --- linux-2.6/drivers/s390/cio/device.c Sat Aug 23 01:58:10 2003
> +++ linux-2.6-s390/drivers/s390/cio/device.c Fri Aug 29 18:55:10 2003
[...]
> @@ -537,8 +537,7 @@
> init_timer(&cdev->private->timer);
>
> /* Set an initial name for the device. */
> - snprintf (cdev->dev.name, DEVICE_NAME_SIZE,"ccw device");
> - snprintf (cdev->dev.bus_id, DEVICE_ID_SIZE, "0:%04x",
> + snprintf (cdev->dev.bus_id, DEVICE_ID_SIZE, "0.0.%04x",
> sch->schib.pmcw.dev);
>
> /* Increase counter of devices currently in recognition. */
Shouldn't the above use BUS_ID_SIZE instead of DEVICE_ID_SIZE?
--
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
next prev parent reply other threads:[~2003-08-29 19:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-08-29 17:10 [PATCH] s390 (5/8): common i/o layer Martin Schwidefsky
2003-08-29 19:25 ` OGAWA Hirofumi [this message]
2003-08-29 20:01 ` OGAWA Hirofumi
2003-08-29 20:24 ` Greg KH
[not found] <pV54.523.43@gated-at.bofh.it>
[not found] ` <pX6U.7Vu.35@gated-at.bofh.it>
2003-08-29 20:31 ` Arnd Bergmann
2003-08-29 20:40 ` Greg KH
2003-08-29 20:50 ` Greg KH
2003-08-29 21:06 ` Arnd Bergmann
2003-08-29 21:09 ` Greg KH
-- strict thread matches above, loose matches on Subject: below --
2003-09-01 7:09 Martin Schwidefsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vfsggtb2.fsf@devron.myhome.or.jp \
--to=hirofumi@mail.parknet.co.jp \
--cc=linux-kernel@vger.kernel.org \
--cc=schwidefsky@de.ibm.com \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox