From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5B97841D63F for ; Tue, 4 Aug 2026 06:56:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=193.142.43.55 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785826585; cv=none; b=kGFazwO2veUJBAvGcxHbF8ALFn4pvHl71WHmLodAp/XomXoCC6oXO4Bi+O07ZAc+7pjoYtb21CS2Xc1Ik4DQezq4cyUXZCtYI2GqEnjdQLUjWICL0TMruKV9m/lpvAE/iXA+RhHyv/PPaOUiYhhJxyjv+zg64h+lQt7XX/tqJNo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785826585; c=relaxed/simple; bh=5YTfKIIbr4uRjA1xYyacYyKpvsI31OL21BsuFiSPLIk=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=SPNLVKYLIP+L8qJUUuEW7Yei45FEsoljDY5euDnnfDPUNg/WODZRYQu/Rz/ihUgbScy/XdEtpIp53bVSvRXorC/GazZgQZ28tyUxPxv3zRsqakanhF2pwRhuoEOZgPC5aLbPbOUmyw+LeRdCc7OGrpOoVH0yRMyxN60gHWrBLtY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de; spf=pass smtp.mailfrom=linutronix.de; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=1PbWulai; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=TTLOGtW/; arc=none smtp.client-ip=193.142.43.55 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linutronix.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="1PbWulai"; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="TTLOGtW/" From: Nam Cao DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1785826581; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=+sVA5YLiRZ+Crq+gCDcO8gb8PAaQnUuMu7sLEwBtUmo=; b=1PbWulaibPGPUjAnPAKtiK6dRU/OHDk7VDOQp+wRf5RMsUWz22w7ZxRsrBSCCCtqFdLUN6 0eRd8INb0hlPkH6g64ulFJndkU+4Me6IoKx5YNxKpMaW0pBj6izKqHmYvxjZ4VDtHluxfU JXOKqMSIhaXOWWJEKaAy2hgXQ4qj6R4N0spQCiAFbLeP/qhH0/UmaHP7BdP4MPEh5TJYHu bkQdSblrs2NgfVAc7eZs2vx1av6dUk2a8uJAhTCHfnNIn1b/omb37Zq4LmDKvypcF5ajqj FRfNehB1R9IRuD79ugM93yEQoMOoEODwFtwBuZqSD4klGYZF+GZwGYom0jJydQ== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1785826581; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=+sVA5YLiRZ+Crq+gCDcO8gb8PAaQnUuMu7sLEwBtUmo=; b=TTLOGtW/rM9CG/skZ+96TUUvcSKWLNCqOxbdYlM4O8dOf+eVyjNbmgzs0mP5/03T0fWjlr NhAkFnDVio7ALkAg== To: Rui Qi , linux-riscv@lists.infradead.org Cc: Rui Qi , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Thomas Gleixner , Zong Li , Conor Dooley , Lukas Gerlach , Deepak Gupta , Ryan Roberts , linux-kernel@vger.kernel.org Subject: Re: [PATCH] riscv: kprobes: Prevent probes in breakpoint handlers In-Reply-To: <20260804064343.1865283-1-qirui.001@bytedance.com> References: <20260804064343.1865283-1-qirui.001@bytedance.com> Date: Tue, 04 Aug 2026 08:56:19 +0200 Message-ID: <87wlu6l6gc.fsf@yellow.woof> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain "Rui Qi" writes: > diff --git a/arch/riscv/kernel/traps.c b/arch/riscv/kernel/traps.c > index 2f57fd48ec28..5eb5785874dd 100644 > --- a/arch/riscv/kernel/traps.c > +++ b/arch/riscv/kernel/traps.c > @@ -270,6 +270,8 @@ static bool probe_single_step_handler(struct pt_regs *regs) > return user ? uprobe_single_step_handler(regs) : kprobe_single_step_handler(regs); > } > > +NOKPROBE_SYMBOL(probe_single_step_handler); > + The usual style is NOKPROBE_SYMBOL() following the function with no blank line. Other than that: Reviewed-by: Nam Cao