public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Rosen Penev <rosenp@gmail.com>
Cc: linux-kernel@vger.kernel.org, "Rafał Miłecki" <rafal@milecki.pl>,
	"Srinivas Kandagatla" <srini@kernel.org>
Subject: Re: [PATCH] nvmem: layouts: u-boot-env: remove ethaddr check
Date: Wed, 29 Apr 2026 09:39:53 +0200	[thread overview]
Message-ID: <87wlxqcj06.fsf@bootlin.com> (raw)
In-Reply-To: <20260428212621.60759-1-rosenp@gmail.com> (Rosen Penev's message of "Tue, 28 Apr 2026 14:26:21 -0700")

Hi Rosen,

> --- a/drivers/nvmem/layouts/u-boot-env.c
> +++ b/drivers/nvmem/layouts/u-boot-env.c
> @@ -75,11 +75,9 @@ static int u_boot_env_parse_cells(struct device *dev, struct nvmem_device *nvmem
>  		info.offset = data_offset + value - data;
>  		info.bytes = strlen(value);
>  		info.np = of_get_child_by_name(dev->of_node, info.name);
> -		if (!strcmp(var, "ethaddr")) {
> -			info.raw_len = strlen(value);
> -			info.bytes = ETH_ALEN;
> -			info.read_post_process = u_boot_env_read_post_process_ethaddr;
> -		}
> +		info.raw_len = strlen(value);
> +		info.bytes = ETH_ALEN;

How do you know this is a MAC address?

Thanks,
Miquèl

  reply	other threads:[~2026-04-29  7:39 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-28 21:26 [PATCH] nvmem: layouts: u-boot-env: remove ethaddr check Rosen Penev
2026-04-29  7:39 ` Miquel Raynal [this message]
2026-04-29  7:44   ` Miquel Raynal
2026-04-29 21:41     ` Rosen Penev
2026-05-06  9:13       ` Miquel Raynal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wlxqcj06.fsf@bootlin.com \
    --to=miquel.raynal@bootlin.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rafal@milecki.pl \
    --cc=rosenp@gmail.com \
    --cc=srini@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox