From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-02.galae.net (smtpout-02.galae.net [185.246.84.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A551730F921 for ; Wed, 4 Feb 2026 10:46:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.246.84.56 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770202012; cv=none; b=NNS3Y9Kq2CQxkfICBrvjtvbN+ZrdKJcPgMEGbCtpkXZiJiWgZ37gGsGMLuq1f00ED5bRgy3u20cuwVka6FfRdrihr8bHvmuBgAVwxvhTSrRb+fUdrWalhYy8fCm7kgRWpZ+DoyfmmuBSGXHdCPRvLKXJQZCo6WB0WUDdvuEHwYg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770202012; c=relaxed/simple; bh=2DhCzRv6yziS4Cexnv9odDyuYjsCkIdutxzLV+shbnk=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=LtT+6I7+TrA5r2LoMC9H0mU2RqfnbGW3X8G89/Ge7IRhimmLRqUpReqwoeViRSLcxEPKRCrKNDaWI8Kel4s61ov4zHG74rP9F1AT8hOts3qYzLbtuTRmHaGtjZ8x1eggwzdmuux6w6nofGeET67sSUHwJSl9/kKUYUG+QmUikjI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=L6/aH8sH; arc=none smtp.client-ip=185.246.84.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="L6/aH8sH" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-02.galae.net (Postfix) with ESMTPS id 218D71A2BDA; Wed, 4 Feb 2026 10:46:50 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id E11C660745; Wed, 4 Feb 2026 10:46:49 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id A2AA4119A8891; Wed, 4 Feb 2026 11:46:45 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1770202009; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=9DcxmSY88sa/IFq/9pI8Ul8RolH6HxvF4wzvh7XRi4E=; b=L6/aH8sHQSj5FIg54ozx8gVU9zRM96vD9SGvib+ARivRLj08b/LQ1tT3/cZpwo2ZyyYnH2 Q0h6z9nfeykNKE8PEEHGF4PxF9dKAu9Zl9qqrAbvQrPxrbcIZbkgZdbEczELtygrgeFa0y Go9tTYe2KYHb1hoXy1A3RwFP9xipG9wyc2tRi0pcFmNVtrCXvdC4gOtR512mMVIJy7/77u O820dOAfz76YI2bmZwQkpVgcQf2/W1odBzZZFEuoX31iBVvR7fHz83ItwD/Bd8yblxj6+H Bwn8Q92kDgyqgyOH9eI5jzRhOwP6WcgAmfz5iA1noZ/1w9/y3W7zKAY+9chfag== From: Miquel Raynal To: Santhosh Kumar K Cc: , , , , , , , , , , , , , , , , Subject: Re: [RFC PATCH v2 01/12] spi: dt-bindings: add spi-has-dqs property In-Reply-To: <20260113141617.1905039-2-s-k6@ti.com> (Santhosh Kumar K.'s message of "Tue, 13 Jan 2026 19:46:06 +0530") References: <20260113141617.1905039-1-s-k6@ti.com> <20260113141617.1905039-2-s-k6@ti.com> User-Agent: mu4e 1.12.7; emacs 30.2 Date: Wed, 04 Feb 2026 11:46:45 +0100 Message-ID: <87wm0sg50q.fsf@bootlin.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Last-TLS-Session-Version: TLSv1.3 On 13/01/2026 at 19:46:06 +0530, Santhosh Kumar K wrote: > Add the optional 'spi-has-dqs' boolean property for SPI flash device > subnodes. This property indicates the flash device supports DQS (Data > Strobe) mode, which provides improved timing margins for data capture > in high-speed SPI operations. > > Signed-off-by: Santhosh Kumar K > --- > .../devicetree/bindings/spi/spi-peripheral-props.yaml | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/Documentation/devicetree/bindings/spi/spi-peripheral-props.y= aml b/Documentation/devicetree/bindings/spi/spi-peripheral-props.yaml > index 8b6e8fc009db..c6f330fd32aa 100644 > --- a/Documentation/devicetree/bindings/spi/spi-peripheral-props.yaml > +++ b/Documentation/devicetree/bindings/spi/spi-peripheral-props.yaml > @@ -89,6 +89,12 @@ properties: > description: > Delay, in microseconds, after a write transfer. >=20=20 > + spi-has-dqs: > + description: > + Indicates the SPI flash device supports DQS (Data Strobe) mode for > + improved data capture timing. > + $ref: /schemas/types.yaml#/definitions/flag This information is currently lacking indeed, mostly because nobody ever cared about it. The DT property is IMO not the correct way to give this information for two reasons: - this is a capability of the chip, we discover the chip dynamically in both cases (NAND and NOR) and attach many capabilities to the chips already, so I believe this information should be provided through a flag. - the fact that the DQS signal might be supported does not indicate it is actually driven. Winbond chips, for instance, can either enable it or not depending on their configuration (probably through their VCR register, I need to check again). The question I have is: shall we enable the DQS pin automatically if it is available? Not all controllers support it I suppose, and wiring the line might as well not be done (or incorrectly). For these cases we may need DT properties in the future. But for the DQS presence indication, I bet it is not useful, and should be handled at the core level (not parsed by the driver like you do) because it may have an impact on the chip internal configuration. I will try to come up with a proposal soon! Cheers, Miqu=C3=A8l