From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 13FF82561AB for ; Fri, 30 Jan 2026 16:17:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769789833; cv=none; b=Ufcl4AxadWhyPFODw3kV/RYNM9Uau93OXZomBF/pfioxwBbBkI61eQxaJpFGizBg0BYidaAKNm3PMaweWi2oErVZy+yeTs4AM2QW03HXSWlaIjrdVTPPg+WdogCHXPmrd4Bh8wcLON4+Z8OyBSs6f5YHuXxkKXEpDUNR1+/kIJg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769789833; c=relaxed/simple; bh=sHnDxdRW99lx+xmRpCCYYm5vuVC3pkuGIo1V8jM843U=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=JkayHBPrkLrv9Bwpxdj7T2qFfXTvRYAKkEuyJkb3q8xKLmyu10R7xHlJgeZGZNLGHSQsQkjFpfVxEz0tecpwIlw7QxYXHURgFTwe9ppx8pVcAle87BAAB9Xuf5/mOFPi+UxGoU8IJdcdBxEcNnzZc+CN4t5lgyL5Mc4DuVqZQ5c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=T8gjX3hr; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="T8gjX3hr" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 04257C4CEF7; Fri, 30 Jan 2026 16:17:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1769789832; bh=sHnDxdRW99lx+xmRpCCYYm5vuVC3pkuGIo1V8jM843U=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=T8gjX3hrVbll026rKhUseD6fXAj6bzKu7rW06iAncc9Tw745WdyLnXr7WjClpqzAM c/PcO5zSf9A6HKiCz3qjrRlB6x+5N+TyayUoLI0GYQubSBQ4mNiBLNazTI8kzp+vO1 9DTRne0WOm4zInKHsKwI97JNXjMr8+w1M3TWWmCFfgK+cfy9UJRhnFKo7bDXSBPsBK ZpC0r10X6sgbr+aAkmXNHLPlYm3pIykiC0bYnQ+SvVXiBjVwkkfkhpLQlYQcGpuegl vXfueCl2vHSY6hHy2HGozAkZ4hX7xrw9FhuRaOjPktjfNCxFbaf5J/BqmLTBN5FqiW sYq6VvZk756Cg== From: Thomas Gleixner To: Mathieu Desnoyers , LKML Cc: Ihor Solodrai , Shrikanth Hegde , Peter Zijlstra , Michael Jeanson Subject: Re: [patch 1/4] sched/mmcid: Prevent live lock on task to CPU mode transition In-Reply-To: <154690d7-9e9f-4d36-a89c-7ed1a57c42ae@efficios.com> References: <20260129210219.452851594@kernel.org> <20260129211557.678686545@kernel.org> <154690d7-9e9f-4d36-a89c-7ed1a57c42ae@efficios.com> Date: Fri, 30 Jan 2026 17:17:09 +0100 Message-ID: <87wm0zjcsa.ffs@tglx> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain On Fri, Jan 30 2026 at 10:24, Mathieu Desnoyers wrote: > On 2026-01-29 16:20, Thomas Gleixner wrote: >> if (percpu) { >> mm_cid_fixup_tasks_to_cpus(); >> + /* Clear the transition bit */ >> + WRITE_ONCE(mm->mm_cid.transit, 0); > > You should move this WRITE_ONCE at the end of > mm_cid_fixup_tasks_to_cpus() to keep the same pattern as for > mm_cid_fixup_cpus_to_tasks(). I fixed that up in the wrong patch. Will fold it back into that one.