From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5325B2FDC26 for ; Fri, 28 Nov 2025 09:24:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764321858; cv=none; b=CR7zzXEbNBFogrf0rqP0SSVU8+UKr9A+UisO7792KPbwgtP1utuN3uM2Xm+rLUFZa3OcN6bsV1zR6jEyiG+9nDYMBzmtazqooIocverM4Jw78mUF3F+TUAMuC2UAbJ37L5FUeYPtQ88paiqtBmVvp1QSIB1R3DP3fcAM4LOh+T4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764321858; c=relaxed/simple; bh=ED9nuiaO8n6F6aMYH2jutdJWyKTjRdS1+Fiwm5emSdo=; h=From:To:Cc:Subject:In-Reply-To:Date:Message-ID:References; b=HgVZajcUMiP/1/l9Av5PgKKXus+mxLSCunNh0GA0AR4JfucSzD7+kNNVgqkREEq3rKW6Oa3ksj8YcX967wrBymvCLMj3hkoHDoXf0phy5g7x+CJeH/tkF2n9uczjO0FyOnHZ5RJNcW2DiFrHy804D0Ni3Anm7u7boGTtqEASu3E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=FPkBbI9G; arc=none smtp.client-ip=209.85.214.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="FPkBbI9G" Received: by mail-pl1-f177.google.com with SMTP id d9443c01a7336-29555b384acso19353295ad.1 for ; Fri, 28 Nov 2025 01:24:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1764321856; x=1764926656; darn=vger.kernel.org; h=references:message-id:date:in-reply-to:subject:cc:to:from:from:to :cc:subject:date:message-id:reply-to; bh=ED9nuiaO8n6F6aMYH2jutdJWyKTjRdS1+Fiwm5emSdo=; b=FPkBbI9GiVnsb0M/Zj7McJfU2Rtk71JMpmlhMLnQROmpakm8KpEhBPOSFP8yjxQ7UH +65YEffKC2iIX+uJlsZpfZ8aY8PIJObwIgxoeuvVU0n/+qL9brNV/WK9b+k0NvG/fzB0 5pp2cZa6V84u9RvDGUVafgO76IUj67obTzfEvgG5GYvt1zEhFtkZQcjnz01qsNZHHXfc cblaFefKaaQk1087WkAJajHkKM+Vdpp+5CtmxIP6Lq34/0bPpFOY9tzEM70yoCTNqSKP xEzPumm/cUN770xG3MvG1XY4jnIhxio13yKxtxggjPdz+NauPGKKoiMMs9Buy01QPnKr YLGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764321856; x=1764926656; h=references:message-id:date:in-reply-to:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ED9nuiaO8n6F6aMYH2jutdJWyKTjRdS1+Fiwm5emSdo=; b=olMBFt9J4Xr70PdO1uYqqL+G1j1cO9G8+zlTQQZq3f5htC41rrGLhGzfVGcFDZFQus DyhZ+oIkdilUTxqPaD1yWquHRrihjnHJWl8UicVK613wQEHULgTVQtSxO62XEHDDKmRO xVlBoWJj+rND0c/vnIlnmjsGAxDBzXBZLjIBC3uW3PmodwZ5smFeBr/cpufg30uptOZs rosFzDvcalAmcPReoPdS72lAobZnpfXSemJCHIkhuOa+B+1s9F2vQX8m2+fOpSN3Beb2 a4Od0CMB+eBjWo7H7mcUIV4Dl7J2QuBA0ulKuV30VtwJkBdfc0m7PQlvJIBT3+gj4C/v E3dQ== X-Forwarded-Encrypted: i=1; AJvYcCVhV94TseXwpdmaUuUMYEzPBNfcAg1qpmE/68xXRnoJQc+LJEPrU4U4S4tUK+nIB81UklfMZem3Gq4hfxM=@vger.kernel.org X-Gm-Message-State: AOJu0YyUOg7bgW8rSLUKr0JkK84w/tk42ceuhAWQyLOn9aLMiWZGc5RZ Su2yJ29O/7eXbK1B49vH3anS/OZ07O1m5UrP9JbM+oXuB5QFfxhc3t4C X-Gm-Gg: ASbGncvyf8ORrhWEuu0VB7mg8WPRBHm1lgL0MMELvpJCh3hHlAPKuxbuHUwCyY/zTBC QvdOLofsmHiDr3eTCU5oM6uU+EbP/Cc2KK772oEuj0wAg7PSKXisA52g6wWcX+7deyZcOCenhZk bykE3bnA6Y103bgwCa2LeIYPQdVqt82royQl+Lo82riRs3Dy6RA+WUuwdH4WkitQUAPaVku3Ofc 3dwxWRZKaqW5qD2BptZJKHIHXW/t64A40YIRzSJMIen70vLyKF57h7d3F1r9ptDT5VNcs3QEATg QX3rEELYRl0ArzSSoIwFXZnEsywvZRSsdkWtpCJ18aTIF3XF35GgEwUTFKdeKK5yHa6URCU0Lap b+0r+Bl7XVywR22SnIo8tMP2qs/U/Bvacync5aSLkxBpmiKPB56Z0dqOtjzIPmiugF4QxEshwP6 PC79sYWCAtBKWSXF0p X-Google-Smtp-Source: AGHT+IFkvqq+4XxuQKa/k2q+LQMu+sa6LTsS3nR8WXj3JiP/G1PdBLLzpGBMoYNmd/LwjyGU4dN/Ig== X-Received: by 2002:a17:902:e54c:b0:24c:7b94:2f53 with SMTP id d9443c01a7336-29b6c3c2913mr349029165ad.6.1764321856487; Fri, 28 Nov 2025 01:24:16 -0800 (PST) Received: from dw-tp ([49.207.234.175]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-29bce478762sm39554625ad.45.2025.11.28.01.24.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Nov 2025 01:24:15 -0800 (PST) From: Ritesh Harjani (IBM) To: David Hildenbrand , linux-kernel@vger.kernel.org Cc: linux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org, David Hildenbrand , Andrew Morton , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , Christophe Leroy , stable@vger.kernel.org Subject: Re: [PATCH v1 1/2] powerpc/pseries/cmm: call balloon_devinfo_init() also without CONFIG_BALLOON_COMPACTION In-Reply-To: <20251021100606.148294-2-david@redhat.com> Date: Fri, 28 Nov 2025 14:37:28 +0530 Message-ID: <87wm3amsof.ritesh.list@gmail.com> References: <20251021100606.148294-1-david@redhat.com> <20251021100606.148294-2-david@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: David Hildenbrand writes: > We always have to initialize the balloon_dev_info, even when compaction > is not configured in: otherwise the containing list and the lock are > left uninitialized. > Agreed cmm uses balloon_dev_info infrastructure beyond just CONFIG_BALLOON_COMPACTION, so it should be initialized by default. The patch looks good to me. Please feel free to add: Reviewed-by: Ritesh Harjani (IBM)