[PATCH] genirq/msi: Remove msi_post_free()

[PATCH] genirq/msi: Remove msi_post_free()

[Nam Cao]

The only user of msi_post_free() - powerpc/pseries - has been changed to
use msi_teardown().

Remove this unused callback.

Signed-off-by: Nam Cao <namcao@linutronix.de>
---
This patch depends on the powerpc/series conversion patch, which is
currently in powerpc tree:
https://lore.kernel.org/lkml/c7a6d8f27fd217021dea4daad777e81a525ae460.1754903590.git.namcao@linutronix.de/

I think it is most convenient to apply this patch to powerpc tree, if
everyone is okay with that?
---
 include/linux/msi.h | 4 ----
 kernel/irq/msi.c    | 3 ---
 2 files changed, 7 deletions(-)

diff --git a/include/linux/msi.h b/include/linux/msi.h
index e5e86a8529fb..faac634ac230 100644
--- a/include/linux/msi.h
+++ b/include/linux/msi.h
@@ -431,8 +431,6 @@ struct msi_domain_info;
  *			function.
  * @domain_free_irqs:	Optional function to override the default free
  *			function.
- * @msi_post_free:	Optional function which is invoked after freeing
- *			all interrupts.
  * @msi_translate:	Optional translate callback to support the odd wire to
  *			MSI bridges, e.g. MBIGEN
  *
@@ -473,8 +471,6 @@ struct msi_domain_ops {
 					     struct device *dev, int nvec);
 	void		(*domain_free_irqs)(struct irq_domain *domain,
 					    struct device *dev);
-	void		(*msi_post_free)(struct irq_domain *domain,
-					 struct device *dev);
 	int		(*msi_translate)(struct irq_domain *domain, struct irq_fwspec *fwspec,
 					 irq_hw_number_t *hwirq, unsigned int *type);
 };
diff --git a/kernel/irq/msi.c b/kernel/irq/msi.c
index 9b09ad3f9914..e7ad99254841 100644
--- a/kernel/irq/msi.c
+++ b/kernel/irq/msi.c
@@ -1644,9 +1644,6 @@ static void msi_domain_free_locked(struct device *dev, struct msi_ctrl *ctrl)
 	else
 		__msi_domain_free_irqs(dev, domain, ctrl);
 
-	if (ops->msi_post_free)
-		ops->msi_post_free(domain, dev);
-
 	if (info->flags & MSI_FLAG_FREE_MSI_DESCS)
 		msi_domain_free_descs(dev, ctrl);
 }
-- 
2.39.5

Re: [PATCH] genirq/msi: Remove msi_post_free()

[Thomas Gleixner]

On Tue, Sep 16 2025 at 08:10, Nam Cao wrote:

> The only user of msi_post_free() - powerpc/pseries - has been changed to
> use msi_teardown().
>
> Remove this unused callback.
>
> Signed-off-by: Nam Cao <namcao@linutronix.de>
> ---
> This patch depends on the powerpc/series conversion patch, which is
> currently in powerpc tree:
> https://lore.kernel.org/lkml/c7a6d8f27fd217021dea4daad777e81a525ae460.1754903590.git.namcao@linutronix.de/
>
> I think it is most convenient to apply this patch to powerpc tree, if
> everyone is okay with that?

Yes.

Reviewed-by: Thomas Gleixner <tglx@linutronix.de>

Re: [PATCH] genirq/msi: Remove msi_post_free()

[Nam Cao]

Nam Cao <namcao@linutronix.de> writes:
> The only user of msi_post_free() - powerpc/pseries - has been changed to
> use msi_teardown().
>
> Remove this unused callback.
>
> Signed-off-by: Nam Cao <namcao@linutronix.de>
> ---
> This patch depends on the powerpc/series conversion patch, which is
> currently in powerpc tree:
> https://lore.kernel.org/lkml/c7a6d8f27fd217021dea4daad777e81a525ae460.1754903590.git.namcao@linutronix.de/
>
> I think it is most convenient to apply this patch to powerpc tree, if
> everyone is okay with that?

Maddy, do you mind picking this up?

Nam

Re: [PATCH] genirq/msi: Remove msi_post_free()

[Madhavan Srinivasan]

On 9/23/25 10:33 AM, Nam Cao wrote:
> Nam Cao <namcao@linutronix.de> writes:
>> The only user of msi_post_free() - powerpc/pseries - has been changed to
>> use msi_teardown().
>>
>> Remove this unused callback.
>>
>> Signed-off-by: Nam Cao <namcao@linutronix.de>
>> ---
>> This patch depends on the powerpc/series conversion patch, which is
>> currently in powerpc tree:
>> https://lore.kernel.org/lkml/c7a6d8f27fd217021dea4daad777e81a525ae460.1754903590.git.namcao@linutronix.de/
>>
>> I think it is most convenient to apply this patch to powerpc tree, if
>> everyone is okay with that?
> 
> Maddy, do you mind picking this up?
> 

Yes, will do

Thanks

> Nam