From: Thomas Gleixner <tglx@linutronix.de>
To: Haofeng Li <920484857@qq.com>, Tony Lindgren <tony@atomide.com>,
Kevin Hilman <khilman@baylibre.com>
Cc: Roger Quadros <rogerq@kernel.org>,
Andreas Kemnade <andreas@kemnade.info>,
Aaro Koskinen <aaro.koskinen@iki.fi>,
linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org,
Haofeng Li <lihaofeng@kylinos.cn>
Subject: Re: [PATCH v1] mfd: twl4030-irq: Fix unused variable warning when CONFIG_OF disabled
Date: Wed, 10 Sep 2025 17:26:23 +0200 [thread overview]
Message-ID: <87wm66s50g.ffs@tglx> (raw)
In-Reply-To: <tencent_C3FBDADE7060045B2952DE00576F922C5E06@qq.com>
On Tue, Jun 17 2025 at 10:41, Haofeng Li wrote:
> -
> - irq_domain_create_legacy(of_fwnode_handle(node), nr_irqs, irq_base, 0,
> +#ifdef CONFIG_OF
> + fwnode = of_fwnode_handle(dev->of_node);
> +#endif
This #ifdeffery is horrible.
> + irq_domain_create_legacy(fwnode, nr_irqs, irq_base, 0,
irq_domain_create_legacy(dev_fwnode(dev), ....
Makes all of those problems go away.
next prev parent reply other threads:[~2025-09-10 15:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-17 2:41 [PATCH v1] mfd: twl4030-irq: Fix unused variable warning when CONFIG_OF disabled Haofeng Li
2025-09-10 15:26 ` Thomas Gleixner [this message]
2025-09-12 10:17 ` Haofeng Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wm66s50g.ffs@tglx \
--to=tglx@linutronix.de \
--cc=920484857@qq.com \
--cc=aaro.koskinen@iki.fi \
--cc=andreas@kemnade.info \
--cc=khilman@baylibre.com \
--cc=lihaofeng@kylinos.cn \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=rogerq@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox