From: Jani Nikula <jani.nikula@linux.intel.com>
To: Lyude Paul <lyude@redhat.com>, Maxime Ripard <mripard@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Cc: "Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"David Airlie" <airlied@gmail.com>,
"Simona Vetter" <simona@ffwll.ch>,
"Miguel Ojeda" <ojeda@kernel.org>,
"Alex Gaynor" <alex.gaynor@gmail.com>,
"Boqun Feng" <boqun.feng@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <benno.lossin@proton.me>,
"Andreas Hindborg" <a.hindborg@kernel.org>,
"Alice Ryhl" <aliceryhl@google.com>,
"Trevor Gross" <tmgross@umich.edu>,
"open list:RUST:Keyword:b(?i:rust)b"
<rust-for-linux@vger.kernel.org>
Subject: Re: [PATCH 1/2] drm/edid: Use unsigned int in drm_add_modes_noedid()
Date: Wed, 26 Mar 2025 12:39:15 +0200 [thread overview]
Message-ID: <87wmcc6ppo.fsf@intel.com> (raw)
In-Reply-To: <20250325212823.669459-2-lyude@redhat.com>
On Tue, 25 Mar 2025, Lyude Paul <lyude@redhat.com> wrote:
> A negative resolution doesn't really make any sense, no one goes into a TV
> store and says "Hello sir, I would like a negative 4K TV please", that
> would make everyone look at you funny.
That is largely the point, though. You know something fishy is going on
when you have a negative resolution. Nobody blinks an eye when you ask
for 4294963K telly, but it's still just as bonkers as that negative 4K.
I think the change at hand is fine, but please let's not pretend using
unsigned somehow protects us from negative numbers.
BR,
Jani.
--
Jani Nikula, Intel
next prev parent reply other threads:[~2025-03-26 10:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-25 21:27 [PATCH 0/2] drm: Make some resolution info unsigned Lyude Paul
2025-03-25 21:27 ` [PATCH 1/2] drm/edid: Use unsigned int in drm_add_modes_noedid() Lyude Paul
2025-03-26 9:29 ` Thomas Zimmermann
2025-03-26 10:39 ` Jani Nikula [this message]
2025-03-26 11:06 ` Miguel Ojeda
2025-03-28 22:27 ` Lyude Paul
2025-03-29 12:04 ` Miguel Ojeda
2025-03-25 21:27 ` [PATCH 2/2] drm/mode_config: Make drm_mode_config.(max|min)_(width|height) signed Lyude Paul
2025-03-26 9:32 ` Thomas Zimmermann
2025-03-26 9:07 ` [PATCH 0/2] drm: Make some resolution info unsigned Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wmcc6ppo.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=a.hindborg@kernel.org \
--cc=airlied@gmail.com \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=benno.lossin@proton.me \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=gary@garyguo.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lyude@redhat.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=simona@ffwll.ch \
--cc=tmgross@umich.edu \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox