Re: 答复: [PATCH V2] ALSA: hda/conexant: fix Z60MR100 startup pop issue

[Takashi Iwai <tiwai@suse.de>]

On Thu, 28 Nov 2024 09:25:22 +0100,
<bo.liu@senarytech.com> wrote:
> 
> > On Thu, 28 Nov 2024 07:08:12 +0100,
> > bo liu wrote:
> > > 
> > > When Z60MR100 startup, speaker will output a pop. To fix this issue, 
> > > we mute codec by init verbs in bios when system startup, and set GPIO 
> > > to low to unmute codec in codec driver when it loaded .
> > > 
> > > Signed-off-by: bo liu <bo.liu@senarytech.com>
> > > ---
> > >  sound/pci/hda/patch_conexant.c | 35 
> > > ++++++++++++++++++++++++++++++++++
> > >  1 file changed, 35 insertions(+)
> > > 
> > > diff --git a/sound/pci/hda/patch_conexant.c 
> > > b/sound/pci/hda/patch_conexant.c index e851785ff058..62c53e64bcad 
> > > 100644
> > > --- a/sound/pci/hda/patch_conexant.c
> > > +++ b/sound/pci/hda/patch_conexant.c
> > > @@ -42,6 +42,7 @@ struct conexant_spec {
> > >  	unsigned int gpio_led;
> > >  	unsigned int gpio_mute_led_mask;
> > >  	unsigned int gpio_mic_led_mask;
> > > +	unsigned int gpio_unmute_bit_mask;
> > >  	bool is_cx8070_sn6140;
> > >  };
> > >  
> > > @@ -308,6 +309,7 @@ enum {
> > >  	CXT_FIXUP_HP_MIC_NO_PRESENCE,
> > >  	CXT_PINCFG_SWS_JS201D,
> > >  	CXT_PINCFG_TOP_SPEAKER,
> > > +	CXT_FIXUP_HP_A_U,
> > >  };
> > >  
> > >  /* for hda_fixup_thinkpad_acpi() */
> > > @@ -762,6 +764,24 @@ static void cxt_setup_mute_led(struct hda_codec
> *codec,
> > >  	}
> > >  }
> > >  
> > > +static void cxt_setup_mute_gpio_and_unmute(struct hda_codec *codec,
> > > +				unsigned int gpio_mute_mask)
> > > +{
> > > +	struct conexant_spec *spec = codec->spec;
> > > +
> > > +	if (gpio_mute_mask) {
> > > +		spec->gpio_unmute_bit_mask = gpio_mute_mask;
> >
> > Any reason to store this in spec?  As far as I see the code below, it's
> used only locally here, so it doesn't have to be stored there.
> 
> The purpose of adding this is to differentiate the configuration of the
> LED_MUTE GPIO and to retain debugging information. Of course, this field can
> be removed if desired.

Yes, please remove.


Takashi