From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 50819DF53; Wed, 31 Jul 2024 19:56:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722455763; cv=none; b=Z9jXOxXr5AYSrAEHPrUBmvuhf5de1muFwcdkm5j0RmYhcbqypSqRTbf73D+IMD6W/ApldWUtsh7sufS9uU4G/QIuYfDxgLfZvk6UjckjAhFAtVLTuQASj2GHEeeKmwFkMtyyvqpWLoOepU3c+XzUo7vVNqau1JSTpAVEPbPLxdc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722455763; c=relaxed/simple; bh=o8N+u0byDeedT1YKt9nGlaJQnl4BOMWVYyEe55Z9/Ig=; h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References: MIME-Version:Content-Type; b=NykrLKtaoGBAWN39wxXXeA4xwESUihOmyAks8WWm2csnW6F8O0hTp7cpFATLnVqSAZBnLoJbQeBH5k9IEp2bfjUcC3MC/RyCHXbnjvAgqeOT/g+JAqnNYI71eTFvr0J8aFl3e9zEEfcp/qyC2Wslpr8m+R5go+vVF6cl4keCupM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ANt9xDQn; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ANt9xDQn" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C7742C116B1; Wed, 31 Jul 2024 19:56:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1722455762; bh=o8N+u0byDeedT1YKt9nGlaJQnl4BOMWVYyEe55Z9/Ig=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=ANt9xDQn4Gb2H/+k7BQBmKlegDc9USQMvOgq9Dr07ezmC41r62uKt+3Sp8UFHdhvB 4zMkm9qW7I1j0d+u98xdzUcCQbYBG53O9hvA5mTWax+Peo71wjaAqMff3ER+uSrAKz pqwQCee70uVSGJj0zBD/XDtqeTGBYI3VEwgyIGR7M9OF6tF/qKBKnTdZTVKsE7O5Id 4oSRNEK2hYpUjhefsXiOdKf+nTmGkAWXSNAzD2QwvIGrnXJrjJY73F9YYFgjX9ZMOs oZFBxurb1Ax9D+zZMjjm4TsoUmnd3LOEYof/7iFKNWuGc8YuMg5zsAu3GifIGLrB98 1PWq7+dReq2jw== Received: from sofa.misterjones.org ([185.219.108.64] helo=wait-a-minute.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1sZFQW-00H6l8-OW; Wed, 31 Jul 2024 20:56:00 +0100 Date: Wed, 31 Jul 2024 20:55:59 +0100 Message-ID: <87wml149ps.wl-maz@kernel.org> From: Marc Zyngier To: Mark Brown Cc: Oliver Upton , James Morse , Suzuki K Poulose , Catalin Marinas , Will Deacon , Fuad Tabba , linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] KVM: arm64: Fix outdated comment about incomplete FGT bitmask definitions In-Reply-To: <20240731-kvm-arm64-fgt-doc-v1-1-abb364f8fe57@kernel.org> References: <20240731-kvm-arm64-fgt-doc-v1-0-abb364f8fe57@kernel.org> <20240731-kvm-arm64-fgt-doc-v1-1-abb364f8fe57@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: broonie@kernel.org, oliver.upton@linux.dev, james.morse@arm.com, suzuki.poulose@arm.com, catalin.marinas@arm.com, will@kernel.org, tabba@google.com, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-kernel@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false On Wed, 31 Jul 2024 19:58:37 +0100, Mark Brown wrote: > > Comments in the code say that our definitions for the FGT registers are not > the generated ones and are updated only as far as DDI0487 J.a however in > commit 9ff67dd26a9e ("KVM: arm64: Use generated FGT RES0 bits instead of > specifying them") we updated to use the generated definitions, and as of > the release of DDI0487 K.a the XML in DD0601 is in sync with the ARM. s/ARM/ARM ARM/. Which revision of the XML? K.a and the latest version of the XML are definitely not in sync. Also, please make use of punctuation. I can't parse this *single* sentence as it stands. > Remove the outdated comment about divergence. > > Fixes: 9ff67dd26a9e ("KVM: arm64: Use generated FGT RES0 bits instead of specifying them") Definitely *not* a fix. M. -- Without deviation from the norm, progress is not possible.