Re: [RFC PATCH v3 22/37] irqchip: Add kvx-core-intc core interrupt controller driver

Yann Sionneau
2024-08-23T13:00:03Z

Hello Krzysztof,

On 22/07/2024 14:32, Krzysztof Kozlowski wrote:
> On 22/07/2024 11:41, ysionneau@kalrayinc.com wrote:
>> From: Yann Sionneau <ysionneau@kalrayinc.com>
>>
>> Each kvx core includes a hardware interrupt controller (core INTC)
>> with the following features:
>> - 32 independent interrupt sources
>> - 4-bit priotity level
>> - Individual interrupt enable bit
>> - Interrupt status bit displaying the pending interrupts
>> - Priority management between the 32 interrupts
>
> ...
>
>> +
>> +static int __init
>> +kvx_init_core_intc(struct device_node *intc, struct device_node *parent)
>> +{
>> + uint32_t core_nr_irqs;
>> + unsigned long cpuid;
>> + int ret;
>> +
>> + ret = kvx_of_parent_cpuid(intc, &cpuid);
>> + if (ret)
>> + panic("core intc has no CPU parent\n");
>> +
>> + if (smp_processor_id() != cpuid) {
>> + fwnode_dev_initialized(of_fwnode_handle(intc), true);
>> + return 0;
>> + }
>> +
>> + if (of_property_read_u32(intc, "kalray,intc-nr-irqs", &core_nr_irqs))
> There is no such property. Stop adding fake properties to your code.

Ack, I will replace this with a CORE_INTC_MAX_IRQ_NUM define

--

Yann