From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6281017BB2F for ; Wed, 10 Apr 2024 22:21:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712787705; cv=none; b=DwBWiTeY2ST9Bsr+5qw/XEWJGLd887rP04eErS22wy70DxwUfhluWTtx9KtCgrhTKpeQM+6u31NVmtmW5V+iwMzYumYhf6LTKPShDDQuEVHtZXkjBKnJhzpHhCmSjOrMbVAfue3aOD9fw8ZDSma8iMiudDOOo2YW34+TmQf+h6c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712787705; c=relaxed/simple; bh=SQyfDI1p8mtUjtI3BfAFLemnAtOtjnfc4UlRkBuRrI0=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=FiPjYonRnJ3CIExAnq1VgPTwqvn+jP6W2TX1jKPA4ciUWKpybQ+Q17EtkyHPJA5s19YmzWofAlNQGwbebfmTP+BgJujePsXVsp8w5hLB9cALWhMIOfnMYFPUKhUlHJVMW1/sC51XsgRyJOsnYefP51LpJrhVSeUNJ6EdJl7AyYE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=TZtD/VsK; arc=none smtp.client-ip=209.85.214.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="TZtD/VsK" Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-1e455b630acso18892895ad.1 for ; Wed, 10 Apr 2024 15:21:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1712787702; x=1713392502; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:user-agent :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=UQ9C1Cr3AvASEU86K/hlf2OO0iCRrNUVuyjVHdlWHE4=; b=TZtD/VsK+Z8FsufyHKK/cZe7E4ZmfhA0V+FOSy/jn7ulFlKbyySF3NETO59AtLHzhp doGV91IEpxMkF9SBODmmYXHD341v8hn4G/Vfd+9bOh0UJq2PaKxcGTeYRzVorRB0qwVw x1hcl1K4kMuZogOvwNTxutBc+aO71hcFDGXv7aF81b+5KWNyVl+WqpKWXqveFcriOiUx IyQWA2AszsSAoz3tINgNr7OFHdwWAwDPTFLCwBWe+uqJU/i28mSd+Yo8xVA/EQwBLIAk z8MR3Ky0ScgmcoOjR9do1rZAug5w1B7yu4NIaqETouvs8g4e0p8XAw2/kAui2Q/4Tflm xKBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712787702; x=1713392502; h=content-transfer-encoding:mime-version:message-id:date:user-agent :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=UQ9C1Cr3AvASEU86K/hlf2OO0iCRrNUVuyjVHdlWHE4=; b=YaFL7Mh0nzM5A4JRv4wR9ccjHtHOSSq1q8TL/+8nSW+IusoqfwMRWcmHdbTaiza3Jk etTbCwhzKqeJ7Q8idjSS4H8fICf/IcIuQz7RfdS/Fj8UoJU1gTCf0sEjD2SEiMCHwi/r eXhlSsvOt0OTjJXE5mzelr82jfZyNX3WC+rmIkVRs9mwyiFso9HEe+nsTjU9nA3l/0Nw 8Fo9/BfuUd4vLv2SGKzTgOVcHy+mz9UQMRForEUo6A+OS7p9goaZMGAcUbNBYHckGUlI nb61GUhSNVWmAt5f8lPWjDymfa4fR9WWfklgSBsdiq2fasLPl9K6mOSnIfubJB5ooh+x zi/w== X-Forwarded-Encrypted: i=1; AJvYcCUJouqOAT6V1gLUlmY+CcQKwnVwnjU06RIz6K7Y756Fi0A+mIbX6ROMi9uIihShPBoyCN+4F6BOEcxa2EYf5venDRvCFF/pn0e+WMjL X-Gm-Message-State: AOJu0YyBwxPC7N72xCi2F0YmWwe4N9YH+z2QwOVqnaWN3dOyRT8reelx 79Dwy60P9v1jDeRQ3DP723WgdgIqykpAHGbbCiv3ybHaaoa/PIeGNSYDVP2CmUM= X-Google-Smtp-Source: AGHT+IEyXjz5iWD+JzMbxman4f15iRJH7qvrzDvYbxC6J1pXkyjcclFUtxHEFXG2Dt+UzEnUxH7BCA== X-Received: by 2002:a17:902:e810:b0:1e3:e081:e7f5 with SMTP id u16-20020a170902e81000b001e3e081e7f5mr5334384plg.66.1712787701595; Wed, 10 Apr 2024 15:21:41 -0700 (PDT) Received: from localhost ([2804:214:8686:5e16:705e:67c9:b3ef:a558]) by smtp.gmail.com with ESMTPSA id q8-20020a170902b10800b001e107222eb5sm39198plr.191.2024.04.10.15.21.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Apr 2024 15:21:41 -0700 (PDT) From: Thiago Jung Bauermann To: Samuel Holland Cc: Andrew Morton , linux-arm-kernel@lists.infradead.org, x86@kernel.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, Christoph Hellwig , loongarch@lists.linux.dev, amd-gfx@lists.freedesktop.org, Alex Deucher Subject: Re: [PATCH v4 13/15] drm/amd/display: Use ARCH_HAS_KERNEL_FPU_SUPPORT In-Reply-To: <20240329072441.591471-14-samuel.holland@sifive.com> (Samuel Holland's message of "Fri, 29 Mar 2024 00:18:28 -0700") References: <20240329072441.591471-1-samuel.holland@sifive.com> <20240329072441.591471-14-samuel.holland@sifive.com> User-Agent: mu4e 1.12.2; emacs 29.3 Date: Wed, 10 Apr 2024 19:21:37 -0300 Message-ID: <87wmp4oo3y.fsf@linaro.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hello, Samuel Holland writes: > Now that all previously-supported architectures select > ARCH_HAS_KERNEL_FPU_SUPPORT, this code can depend on that symbol instead > of the existing list of architectures. It can also take advantage of the > common kernel-mode FPU API and method of adjusting CFLAGS. > > Acked-by: Alex Deucher > Reviewed-by: Christoph Hellwig > Signed-off-by: Samuel Holland Unfortunately this patch causes build failures on arm with allyesconfig and allmodconfig. Tested with next-20240410. Error with allyesconfig: $ make -j 8 \ O=3D$HOME/.cache/builds/linux-cross-arm \ ARCH=3Darm \ CROSS_COMPILE=3Darm-linux-gnueabihf- make[1]: Entering directory '/home/bauermann/.cache/builds/linux-cross-arm' =E2=8B=AE arm-linux-gnueabihf-ld: drivers/gpu/drm/amd/display/dc/dml/dcn20/dcn20_fpu.= o: in function `dcn20_populate_dml_pipes_from_context': dcn20_fpu.c:(.text+0x20f4): undefined reference to `__aeabi_l2d' arm-linux-gnueabihf-ld: dcn20_fpu.c:(.text+0x210c): undefined reference to = `__aeabi_l2d' arm-linux-gnueabihf-ld: dcn20_fpu.c:(.text+0x2124): undefined reference to = `__aeabi_l2d' arm-linux-gnueabihf-ld: dcn20_fpu.c:(.text+0x213c): undefined reference to = `__aeabi_l2d' arm-linux-gnueabihf-ld: drivers/gpu/drm/amd/display/dc/dml/calcs/dcn_calcs.= o: in function `pipe_ctx_to_e2e_pipe_params': dcn_calcs.c:(.text+0x390): undefined reference to `__aeabi_l2d' arm-linux-gnueabihf-ld: drivers/gpu/drm/amd/display/dc/dml/calcs/dcn_calcs.= o:dcn_calcs.c:(.text+0x3a4): more undefined references to `__aeabi_l2d' fol= low arm-linux-gnueabihf-ld: drivers/gpu/drm/amd/display/dc/dml2/dml2_wrapper.o:= in function `optimize_configuration': dml2_wrapper.c:(.text+0xcbc): undefined reference to `__aeabi_d2ulz' arm-linux-gnueabihf-ld: drivers/gpu/drm/amd/display/dc/dml2/dml2_translatio= n_helper.o: in function `populate_dml_plane_cfg_from_plane_state': dml2_translation_helper.c:(.text+0x9e4): undefined reference to `__aeabi_l2= d' arm-linux-gnueabihf-ld: dml2_translation_helper.c:(.text+0xa20): undefined = reference to `__aeabi_l2d' arm-linux-gnueabihf-ld: dml2_translation_helper.c:(.text+0xa58): undefined = reference to `__aeabi_l2d' arm-linux-gnueabihf-ld: dml2_translation_helper.c:(.text+0xa90): undefined = reference to `__aeabi_l2d' make[3]: *** [/home/bauermann/src/linux/scripts/Makefile.vmlinux:37: vmlinu= x] Error 1 make[2]: *** [/home/bauermann/src/linux/Makefile:1165: vmlinux] Error 2 make[1]: *** [/home/bauermann/src/linux/Makefile:240: __sub-make] Error 2 make[1]: Leaving directory '/home/bauermann/.cache/builds/linux-cross-arm' make: *** [Makefile:240: __sub-make] Error 2 The error with allmodconfig is slightly different: $ make -j 8 \ O=3D$HOME/.cache/builds/linux-cross-arm \ ARCH=3Darm \ CROSS_COMPILE=3Darm-linux-gnueabihf- make[1]: Entering directory '/home/bauermann/.cache/builds/linux-cross-arm' =E2=8B=AE ERROR: modpost: "__aeabi_d2ulz" [drivers/gpu/drm/amd/amdgpu/amdgpu.ko] unde= fined! ERROR: modpost: "__aeabi_l2d" [drivers/gpu/drm/amd/amdgpu/amdgpu.ko] undefi= ned! make[3]: *** [/home/bauermann/src/linux/scripts/Makefile.modpost:145: Modul= e.symvers] Error 1 make[2]: *** [/home/bauermann/src/linux/Makefile:1876: modpost] Error 2 make[1]: *** [/home/bauermann/src/linux/Makefile:240: __sub-make] Error 2 make[1]: Leaving directory '/home/bauermann/.cache/builds/linux-cross-arm' make: *** [Makefile:240: __sub-make] Error 2 -- Thiago