From: John Ogness <john.ogness@linutronix.de>
To: Petr Mladek <pmladek@suse.com>,
Sergey Senozhatsky <senozhatsky@chromium.org>,
Steven Rostedt <rostedt@goodmis.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Todd Brandt <todd.e.brandt@intel.com>,
linux-kernel@vger.kernel.org, Petr Mladek <pmladek@suse.com>
Subject: Re: [PATCH v2 2/2] printk: Reduce pr_flush() pooling time
Date: Fri, 06 Oct 2023 12:18:06 +0206 [thread overview]
Message-ID: <87wmw0vz49.fsf@jogness.linutronix.de> (raw)
In-Reply-To: <20231006082151.6969-3-pmladek@suse.com>
On 2023-10-06, Petr Mladek <pmladek@suse.com> wrote:
> pr_flush() does not guarantee that all messages would really get flushed
> to the console. The best it could do is to wait with a given timeout.[*]
>
> The current interval 100ms for checking the progress might seem too
> long in some situations. For example, such delays are not appreciated
> during suspend and resume especially when the consoles have been flushed
> "long" time before the check.
>
> One the other hand, the sleeping wait might be useful in other situations.
"One" should be "On"
Otherwise the patch looks OK to me. Thanks!
Reviewed-by: John Ogness <john.ogness@linutronix.de>
next prev parent reply other threads:[~2023-10-06 10:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-06 8:21 [PATCH v2 0/2] printk: Reduce unnecessary wait times by pr_flush() Petr Mladek
2023-10-06 8:21 ` [PATCH v2 1/2] printk: flush consoles before checking progress Petr Mladek
2023-10-06 8:21 ` [PATCH v2 2/2] printk: Reduce pr_flush() pooling time Petr Mladek
2023-10-06 10:12 ` John Ogness [this message]
2023-10-10 8:44 ` [PATCH v2 0/2] printk: Reduce unnecessary wait times by pr_flush() Petr Mladek
2023-10-10 11:38 ` John Ogness
2023-10-11 12:10 ` Petr Mladek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wmw0vz49.fsf@jogness.linutronix.de \
--to=john.ogness@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=senozhatsky@chromium.org \
--cc=tglx@linutronix.de \
--cc=todd.e.brandt@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox