From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6E42E7D0A4 for ; Thu, 21 Sep 2023 19:03:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230143AbjIUTDJ (ORCPT ); Thu, 21 Sep 2023 15:03:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42452 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230382AbjIUTCp (ORCPT ); Thu, 21 Sep 2023 15:02:45 -0400 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 454EF8BD24 for ; Thu, 21 Sep 2023 10:41:55 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id ED3EC338A0; Thu, 21 Sep 2023 07:03:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1695279791; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=masS9gkY9Jl4ki7h+NB8IOeo+oB/UaEHw5Kk8HG6w48=; b=YiVz+HfbczILR0YqIMhG3/yqIlhwI4X3p7etp0Hq5sKWUfJPUjqVZI+5UGc2RCqeSx/B+O f4MHtFmOzPjCMHg9+5lpugRo7Aad4b7uMgv+dpnoo4Ygrp7RvxGudUYWes/xjLSr0zFQzy dqySvJS4aJCH0xHWutcgln3PnFPr8YQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1695279791; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=masS9gkY9Jl4ki7h+NB8IOeo+oB/UaEHw5Kk8HG6w48=; b=wcwML8meNly0O4NEO10L4HcN+RHFvL9Y9OoId9FM1xhzNdXg17WcGt0BQbPgz8CzjSqzPv VEmJwmAy5tWuy5AQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id C814113513; Thu, 21 Sep 2023 07:03:11 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 7nj8L6/qC2UPawAAMHmgww (envelope-from ); Thu, 21 Sep 2023 07:03:11 +0000 Date: Thu, 21 Sep 2023 09:03:11 +0200 Message-ID: <87wmwkt3dc.wl-tiwai@suse.de> From: Takashi Iwai To: Abelardo Ricart Cc: linux-kernel@vger.kernel.org, perex@perex.cz, tiwai@suse.com, alsa-devel@alsa-project.org Subject: Re: [PATCHv2] ALSA: hda/realtek: Add quirk for ASUS ROG G533Q In-Reply-To: <348823a2-af40-42d5-af30-dc00eaf1d90a@gmail.com> References: <348823a2-af40-42d5-af30-dc00eaf1d90a@gmail.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 21 Sep 2023 08:58:37 +0200, Abelardo Ricart wrote: > > The same quirk applied to the ASUS G533Z is also applicable to the ASUS > G533Q (of which I am an owner and have thus tested). Resubmitted for > e-mail formatting issue. You don't need to mention about resubmission in the patch description here. It can be put under the line "---" instead; then it won't be taken into the git commit log. In anyway, the problem isn't fixed... > Signed-off-by: Abelardo Ricart > --- > diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c > index b7e78bfcffd8..7bb3c1e05bf2 100644 > --- a/sound/pci/hda/patch_realtek.c > +++ b/sound/pci/hda/patch_realtek.c > @@ -9781,6 +9781,7 @@ static const struct snd_pci_quirk > alc269_fixup_tbl[] = { > SND_PCI_QUIRK(0x1043, 0x1493, "ASUS GV601V", > ALC285_FIXUP_ASUS_HEADSET_MIC), > SND_PCI_QUIRK(0x1043, 0x1517, "Asus Zenbook > UX31A",ALC269VB_FIXUP_ASUS_ZENBOOK_UX31A), > SND_PCI_QUIRK(0x1043, 0x1573, "ASUS GZ301V", > ALC285_FIXUP_ASUS_HEADSET_MIC), > + SND_PCI_QUIRK(0x1043, 0x1602, "ASUS ROG Strix G15 > (G533Q)",ALC285_FIXUP_ASUS_G533Z_PINS), > SND_PCI_QUIRK(0x1043, 0x1662, "ASUS GV301QH", ALC294_FIXUP_ASUS_DUAL_SPK), > SND_PCI_QUIRK(0x1043, 0x1683, "ASUS UM3402YAR", > ALC287_FIXUP_CS35L41_I2C_2), > SND_PCI_QUIRK(0x1043, 0x16b2, "ASUS GU603", ALC289_FIXUP_ASUS_GA401), ... now all spaces are gone completely. Takashi