From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E22DDEEAA4C for ; Thu, 14 Sep 2023 14:37:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239880AbjINOhd (ORCPT ); Thu, 14 Sep 2023 10:37:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40230 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233693AbjINOha (ORCPT ); Thu, 14 Sep 2023 10:37:30 -0400 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DE3D21AD for ; Thu, 14 Sep 2023 07:37:25 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id A1FF521842; Thu, 14 Sep 2023 14:37:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1694702244; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=lZRieROqbwcDhGtcftY4gNUE3C/0M9g8+nAIb/BCYK8=; b=cp6fCWVmRmhxGFp2vxv37JeKGKUzTZz5QvZQtfmU/3DLy+XlaKWpBJnwRWOi+CNFo16MgN X1g/kaJ9coBrYxaB5sQEJldmBAe9TljMQJKVXRBUoxNx1zSHWyT0ESY295aAurJwKioIrm gX7UsaGaoiEqnxGJUmw6aQep07MgQs8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1694702244; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=lZRieROqbwcDhGtcftY4gNUE3C/0M9g8+nAIb/BCYK8=; b=CYblOK5z/3NzYmTTCuwIY3/csHiYxFVfB0NXTnNAnQYhcpuWjCRZh+pMqGb91pusfgOKFr 2zM4SARn5zIzeuAg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 7D7DE139DB; Thu, 14 Sep 2023 14:37:24 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 3Rd4HaQaA2WweAAAMHmgww (envelope-from ); Thu, 14 Sep 2023 14:37:24 +0000 Date: Thu, 14 Sep 2023 16:37:23 +0200 Message-ID: <87wmwsyg64.wl-tiwai@suse.de> From: Takashi Iwai To: Richard Fitzgerald Cc: , , , Subject: Re: [PATCH] ALSA: hda: cs35l56: Don't 'return ret' if ret is always zero In-Reply-To: <20230914140852.7112-1-rf@opensource.cirrus.com> References: <20230914140852.7112-1-rf@opensource.cirrus.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 14 Sep 2023 16:08:52 +0200, Richard Fitzgerald wrote: > > The final return in cs35l56_hda_posture_get() was returning the > value of 'ret', but ret is always zero at this point. So this > can be a simple 'return 0'. > > Signed-off-by: Richard Fitzgerald Thanks, applied. Takashi