public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/i915_drm.h: fix a typo
@ 2023-05-29  7:49 Sui Jingfeng
  2023-05-29  8:06 ` Jani Nikula
  0 siblings, 1 reply; 5+ messages in thread
From: Sui Jingfeng @ 2023-05-29  7:49 UTC (permalink / raw)
  To: Jani Nikula, Joonas Lahtinen, Rodrigo Vivi, Tvrtko Ursulin,
	David Airlie, Daniel Vetter
  Cc: intel-gfx, dri-devel, linux-kernel

 'rbiter' -> 'arbite'

Signed-off-by: Sui Jingfeng <suijingfeng@loongson.cn>
---
 include/drm/i915_drm.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/drm/i915_drm.h b/include/drm/i915_drm.h
index 7adce327c1c2..3dcb1db519ae 100644
--- a/include/drm/i915_drm.h
+++ b/include/drm/i915_drm.h
@@ -42,7 +42,7 @@ extern struct resource intel_graphics_stolen_res;
  * The Bridge device's PCI config space has information about the
  * fb aperture size and the amount of pre-reserved memory.
  * This is all handled in the intel-gtt.ko module. i915.ko only
- * cares about the vga bit for the vga rbiter.
+ * cares about the vga bit for the vga arbite.
  */
 #define INTEL_GMCH_CTRL		0x52
 #define INTEL_GMCH_VGA_DISABLE  (1 << 1)
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH] drm/i915_drm.h: fix a typo
  2023-05-29  7:49 [PATCH] drm/i915_drm.h: fix a typo Sui Jingfeng
@ 2023-05-29  8:06 ` Jani Nikula
  2023-05-29  8:47   ` Sui Jingfeng
  0 siblings, 1 reply; 5+ messages in thread
From: Jani Nikula @ 2023-05-29  8:06 UTC (permalink / raw)
  To: Sui Jingfeng, Joonas Lahtinen, Rodrigo Vivi, Tvrtko Ursulin,
	David Airlie, Daniel Vetter
  Cc: intel-gfx, dri-devel, linux-kernel

On Mon, 29 May 2023, Sui Jingfeng <suijingfeng@loongson.cn> wrote:
>  'rbiter' -> 'arbite'

Should be arbiter.

>
> Signed-off-by: Sui Jingfeng <suijingfeng@loongson.cn>
> ---
>  include/drm/i915_drm.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/drm/i915_drm.h b/include/drm/i915_drm.h
> index 7adce327c1c2..3dcb1db519ae 100644
> --- a/include/drm/i915_drm.h
> +++ b/include/drm/i915_drm.h
> @@ -42,7 +42,7 @@ extern struct resource intel_graphics_stolen_res;
>   * The Bridge device's PCI config space has information about the
>   * fb aperture size and the amount of pre-reserved memory.
>   * This is all handled in the intel-gtt.ko module. i915.ko only
> - * cares about the vga bit for the vga rbiter.
> + * cares about the vga bit for the vga arbite.
>   */
>  #define INTEL_GMCH_CTRL		0x52
>  #define INTEL_GMCH_VGA_DISABLE  (1 << 1)

-- 
Jani Nikula, Intel Open Source Graphics Center

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] drm/i915_drm.h: fix a typo
  2023-05-29  8:06 ` Jani Nikula
@ 2023-05-29  8:47   ` Sui Jingfeng
  2023-05-29 10:06     ` Jani Nikula
  0 siblings, 1 reply; 5+ messages in thread
From: Sui Jingfeng @ 2023-05-29  8:47 UTC (permalink / raw)
  To: Jani Nikula, Joonas Lahtinen, Rodrigo Vivi, Tvrtko Ursulin,
	David Airlie, Daniel Vetter
  Cc: intel-gfx, dri-devel, linux-kernel

Hi,


On 2023/5/29 16:06, Jani Nikula wrote:
> On Mon, 29 May 2023, Sui Jingfeng <suijingfeng@loongson.cn> wrote:
>>   'rbiter' -> 'arbite'
> Should be arbiter.

Yeah, should be arbiter.

arbiter is a noun. Here, this arbiter may referrer to the 
drivers/pci/vgaarb.c.

Can you help correct then apply it ? thanks.

>
>> Signed-off-by: Sui Jingfeng <suijingfeng@loongson.cn>
>> ---
>>   include/drm/i915_drm.h | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/include/drm/i915_drm.h b/include/drm/i915_drm.h
>> index 7adce327c1c2..3dcb1db519ae 100644
>> --- a/include/drm/i915_drm.h
>> +++ b/include/drm/i915_drm.h
>> @@ -42,7 +42,7 @@ extern struct resource intel_graphics_stolen_res;
>>    * The Bridge device's PCI config space has information about the
>>    * fb aperture size and the amount of pre-reserved memory.
>>    * This is all handled in the intel-gtt.ko module. i915.ko only
>> - * cares about the vga bit for the vga rbiter.
>> + * cares about the vga bit for the vga arbite.
>>    */
>>   #define INTEL_GMCH_CTRL		0x52
>>   #define INTEL_GMCH_VGA_DISABLE  (1 << 1)

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] drm/i915_drm.h: fix a typo
  2023-05-29  8:47   ` Sui Jingfeng
@ 2023-05-29 10:06     ` Jani Nikula
  2023-05-29 11:20       ` Sui Jingfeng
  0 siblings, 1 reply; 5+ messages in thread
From: Jani Nikula @ 2023-05-29 10:06 UTC (permalink / raw)
  To: Sui Jingfeng, Joonas Lahtinen, Rodrigo Vivi, Tvrtko Ursulin,
	David Airlie, Daniel Vetter
  Cc: intel-gfx, dri-devel, linux-kernel

On Mon, 29 May 2023, Sui Jingfeng <15330273260@189.cn> wrote:
> Hi,
>
>
> On 2023/5/29 16:06, Jani Nikula wrote:
>> On Mon, 29 May 2023, Sui Jingfeng <suijingfeng@loongson.cn> wrote:
>>>   'rbiter' -> 'arbite'
>> Should be arbiter.
>
> Yeah, should be arbiter.
>
> arbiter is a noun. Here, this arbiter may referrer to the 
> drivers/pci/vgaarb.c.
>
> Can you help correct then apply it ? thanks.

Please send a fixed version and I'll apply it. I'm not fixing trivial
patches for you.

BR,
Jani.


>
>>
>>> Signed-off-by: Sui Jingfeng <suijingfeng@loongson.cn>
>>> ---
>>>   include/drm/i915_drm.h | 2 +-
>>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/include/drm/i915_drm.h b/include/drm/i915_drm.h
>>> index 7adce327c1c2..3dcb1db519ae 100644
>>> --- a/include/drm/i915_drm.h
>>> +++ b/include/drm/i915_drm.h
>>> @@ -42,7 +42,7 @@ extern struct resource intel_graphics_stolen_res;
>>>    * The Bridge device's PCI config space has information about the
>>>    * fb aperture size and the amount of pre-reserved memory.
>>>    * This is all handled in the intel-gtt.ko module. i915.ko only
>>> - * cares about the vga bit for the vga rbiter.
>>> + * cares about the vga bit for the vga arbite.
>>>    */
>>>   #define INTEL_GMCH_CTRL		0x52
>>>   #define INTEL_GMCH_VGA_DISABLE  (1 << 1)

-- 
Jani Nikula, Intel Open Source Graphics Center

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] drm/i915_drm.h: fix a typo
  2023-05-29 10:06     ` Jani Nikula
@ 2023-05-29 11:20       ` Sui Jingfeng
  0 siblings, 0 replies; 5+ messages in thread
From: Sui Jingfeng @ 2023-05-29 11:20 UTC (permalink / raw)
  To: Jani Nikula, Joonas Lahtinen, Rodrigo Vivi, Tvrtko Ursulin,
	David Airlie, Daniel Vetter
  Cc: intel-gfx, dri-devel, linux-kernel

Hi,


I'm just hesitating to so, thank you.


On 2023/5/29 18:06, Jani Nikula wrote:
> On Mon, 29 May 2023, Sui Jingfeng <15330273260@189.cn> wrote:
>> Hi,
>>
>>
>> On 2023/5/29 16:06, Jani Nikula wrote:
>>> On Mon, 29 May 2023, Sui Jingfeng <suijingfeng@loongson.cn> wrote:
>>>>    'rbiter' -> 'arbite'
>>> Should be arbiter.
>> Yeah, should be arbiter.
>>
>> arbiter is a noun. Here, this arbiter may referrer to the
>> drivers/pci/vgaarb.c.
>>
>> Can you help correct then apply it ? thanks.
> Please send a fixed version and I'll apply it. I'm not fixing trivial
> patches for you.
>
> BR,
> Jani.
>
>
>>>> Signed-off-by: Sui Jingfeng <suijingfeng@loongson.cn>
>>>> ---
>>>>    include/drm/i915_drm.h | 2 +-
>>>>    1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/include/drm/i915_drm.h b/include/drm/i915_drm.h
>>>> index 7adce327c1c2..3dcb1db519ae 100644
>>>> --- a/include/drm/i915_drm.h
>>>> +++ b/include/drm/i915_drm.h
>>>> @@ -42,7 +42,7 @@ extern struct resource intel_graphics_stolen_res;
>>>>     * The Bridge device's PCI config space has information about the
>>>>     * fb aperture size and the amount of pre-reserved memory.
>>>>     * This is all handled in the intel-gtt.ko module. i915.ko only
>>>> - * cares about the vga bit for the vga rbiter.
>>>> + * cares about the vga bit for the vga arbite.
>>>>     */
>>>>    #define INTEL_GMCH_CTRL		0x52
>>>>    #define INTEL_GMCH_VGA_DISABLE  (1 << 1)

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2023-05-29 11:20 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-05-29  7:49 [PATCH] drm/i915_drm.h: fix a typo Sui Jingfeng
2023-05-29  8:06 ` Jani Nikula
2023-05-29  8:47   ` Sui Jingfeng
2023-05-29 10:06     ` Jani Nikula
2023-05-29 11:20       ` Sui Jingfeng

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox