From: Takashi Iwai <tiwai@suse.de>
To: Oswald Buddenhagen <oswald.buddenhagen@gmx.de>
Cc: Tom Rix <trix@redhat.com>,
perex@perex.cz, tiwai@suse.com, alsa-devel@alsa-project.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ALSA: emu10k1: set variables emu1010_routing_info and emu1010_pads_info storage-class-specifier to static
Date: Thu, 18 May 2023 16:31:46 +0200 [thread overview]
Message-ID: <87wn15hfsd.wl-tiwai@suse.de> (raw)
In-Reply-To: <ZGYvG2Sf9ZeeOmL6@ugly>
On Thu, 18 May 2023 15:58:51 +0200,
Oswald Buddenhagen wrote:
>
> On Thu, May 18, 2023 at 08:38:26AM -0400, Tom Rix wrote:
> > smatch reports
> ^^^^^^ is this the best word to use here?
Note that smatch is a name of a static analysis tool :)
> > sound/pci/emu10k1/emumixer.c:519:39: warning: symbol
> > 'emu1010_routing_info' was not declared. Should it be static?
> > sound/pci/emu10k1/emumixer.c:859:36: warning: symbol
> > 'emu1010_pads_info' was not declared. Should it be static?
> >
> > These variables are only used in their defining file, so it should be static
> ^^ they
> >
> > Signed-off-by: Tom Rix <trix@redhat.com>
> >
> Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@gmx.de>
>
> (also amending one of the still pending patches. thanks!)
Applied the patch now, thanks.
Takashi
prev parent reply other threads:[~2023-05-18 14:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-18 12:38 [PATCH] ALSA: emu10k1: set variables emu1010_routing_info and emu1010_pads_info storage-class-specifier to static Tom Rix
2023-05-18 13:58 ` Oswald Buddenhagen
2023-05-18 14:18 ` Tom Rix
2023-05-18 14:31 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wn15hfsd.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oswald.buddenhagen@gmx.de \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
--cc=trix@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox